Rename TrainState.epoch as TrainState.iteration to better represent its actual meaning. #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lululxvi
reviewed
Mar 14, 2025
KangyuWeng
force-pushed
the
trainstate_iteration
branch
from
5db03b4 to
e59bb6a
Compare
KangyuWeng
force-pushed
the
trainstate_iteration
branch
from
e59bb6a to
c48754a
Compare
lululxvi
reviewed
Mar 14, 2025
lululxvi
reviewed
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three commits. The first commit renames epoch as iteration. TrainState.epoch can still be used for now, but a warning will be raised each time it is used. The second commit changes all TrainState.epoch to TrainState.iteration in deepxde. The third commit replaces epochs in the document with iterations because epochs in Model.train() is depreciated long ago.