BACKEND PyTorch : Add PFNN features #1966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(I also added the regularizer, just like FNN) |
Owner
|
To make it easy to merge, could you split this into two PRs: one for regularizer and one for network? |
Contributor
Author
|
I removed the regularizer, I'll make another PR after |
Owner
|
The regularizer code is merged #1968. Is there any update needed for this PR? |
Contributor
Author
|
This one is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to remerge the subnetworks after splitting and the last layer can be a list of each subnetwork output size before concatenation.
The modification is copied from what I did previously for JAX backend. #1671