Fix for PyTorch MPS support #1990
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tensor operations occur during "torch._dynamo.disable()", which may lead to crash if the default device has already been set to MPS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This is a fix for setting the default PyTorch device to be MPS.
Before: first
torch.set_default_device("mps"), thentorch._dynamo.disable().Now: vice versa.
Some tensor operations occur during "torch._dynamo.disable()" (which is used to cope with the PyTorch optimizer bug), which may lead to crash if the default device has already been set to MPS.
I apologize: for the previous MPS pull request I could not test the code well enough. I had no Apple Silicon device, so I asked one person to check the code sequence for me, and probably a misunderstanding happened. This time I received an M4 MacBook and tested everything by myself.