Commit bf2446b
fix(test): test_offset_commit_atomicity must not kill the source worker
The test was calling kill_random_worker() without a stage filter, so
~1/3 of runs picked the source worker. Source has parallelism=(1,1)
and no offset-checkpoint logic, so once the source actor dies the
pipeline cannot resume production — and the test ends with ~600
source records never produced, which after the modulo-3 filter shows
up as ~199 records missing (matches the CI failure exactly).
The chaos tests in test_chaos_stress.py already restrict to
stage_id="transform" with a one-line comment explaining why; copy
that here.
This is the *test* bug. The earlier publish-commit race (PR #84
storage.rs fixes) was a real engine bug and stays fixed. The test
also exercises that bug path — but on top of it, this misuse of
kill_random_worker was masking the test as still-broken even after
the engine-side fix landed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent aea1d19 commit bf2446b
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
517 | 517 | | |
518 | 518 | | |
519 | 519 | | |
520 | | - | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
521 | 528 | | |
522 | 529 | | |
523 | 530 | | |
524 | | - | |
| 531 | + | |
525 | 532 | | |
526 | 533 | | |
527 | 534 | | |
| |||
0 commit comments