chore(slideshow): keep swipe only on touch device

Author: gcornut

CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+-   Keep slideshow swipe only on touch device.
+
+### Fixed
+
+-   Updated lodash from 4.17.19 to 4.17.21 to fix potential security risks.
+
 ## [1.0.15][] - 2021-05-03
 
 ### Added

packages/lumx-angularjs/package.json

@@ -9,7 +9,7 @@
         "@lumx/core": "^1.0.15",
         "@lumx/icons": "^1.0.15",
         "focus-visible": "^5.0.2",
-        "lodash": "4.17.19",
+        "lodash": "4.17.21",
         "popper.js": "^1.16.0"
     },
     "description": "The official LumApps Design System (LumX) for AngularJS applications",

packages/lumx-core/package.json

@@ -8,7 +8,7 @@
     "dependencies": {
         "classnames": "^2.2.6",
         "focus-visible": "^5.0.2",
-        "lodash": "4.17.19",
+        "lodash": "4.17.21",
         "sass-mq": "^5.0.0"
     },
     "description": "LumX core",

packages/lumx-react/package.json

@@ -83,7 +83,7 @@
         "yarn": "^1.19.1"
     },
     "peerDependencies": {
-        "lodash": "4.17.19",
+        "lodash": "4.17.21",
         "moment": "^2.24.0",
         "moment-range": "^4.0.2",
         "react": "^16.13.0",

packages/lumx-react/src/components/slideshow/useKeyOrSwipeNavigate.ts

@@ -1,6 +1,8 @@
 import { useEffect } from 'react';
 import { detectSwipe } from '@lumx/core/js/utils';
 
+const isTouchDevice = () => 'ontouchstart' in window;
+
 /**
  * Listen keyboard and swipe to navigate left and right.
  */
@@ -28,10 +30,10 @@ export function useKeyOrSwipeNavigate(
         };
 
         element.addEventListener('keydown', onNavigate);
-        const removeSwipeListeners = detectSwipe(element, onNavigate);
+        const removeSwipeListeners = isTouchDevice() ? detectSwipe(element, onNavigate) : undefined;
         return () => {
             element.removeEventListener('keydown', onNavigate);
-            removeSwipeListeners();
+            removeSwipeListeners?.();
         };
     }, [onPrevious, onNext, element]);
 }

packages/site-demo/package.json

@@ -42,7 +42,7 @@
         "gatsby-source-filesystem": "^2.3.36",
         "gatsby-transformer-remark": "^2.8.46",
         "intersection-observer": "^0.7.0",
-        "lodash": "4.17.19",
+        "lodash": "4.17.21",
         "moment": "^2.24.0",
         "moment-range": "^4.0.2",
         "prism-react-renderer": "^0.1.5",

packages/yo-generators/package.json

@@ -1,7 +1,7 @@
 {
     "dependencies": {
         "chalk": "^2.4.2",
-        "lodash": "4.17.19",
+        "lodash": "4.17.21",
         "yeoman-generator": "^4.1.0",
         "yosay": "^2.0.2"
     },

yarn.lock

@@ -17846,16 +17846,21 @@ lodash.without@^4.4.0:
   resolved "https://registry.yarnpkg.com/lodash.without/-/lodash.without-4.4.0.tgz#3cd4574a00b67bae373a94b748772640507b7aac"
   integrity sha1-PNRXSgC2e643OpS3SHcmQFB7eqw=
 
-[email protected].19, lodash@^4.17.19:
-  version "4.17.19"
-  resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.19.tgz#e48ddedbe30b3321783c5b4301fbd353bc1e4a4b"
-  integrity sha512-JNvd8XER9GQX0v2qJgsaN/mzFCNA5BRe/j8JN9d+tWyGLSodKQHKFicdwNYzWwI3wjRnaKPsGj1XkBjx/F96DQ==
+[email protected].21:
+  version "4.17.21"
+  resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
+  integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
 
 lodash@^4.0.0, lodash@^4.0.1, lodash@^4.15.0, lodash@^4.17.10, lodash@^4.17.11, lodash@^4.17.12, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.2, lodash@^4.17.4, lodash@^4.17.5, lodash@^4.2.1, lodash@^4.3.0, lodash@~4.17.10:
   version "4.17.15"
   resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.15.tgz#b447f6670a0455bbfeedd11392eff330ea097548"
   integrity sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A==
 
+lodash@^4.17.19:
+  version "4.17.19"
+  resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.19.tgz#e48ddedbe30b3321783c5b4301fbd353bc1e4a4b"
+  integrity sha512-JNvd8XER9GQX0v2qJgsaN/mzFCNA5BRe/j8JN9d+tWyGLSodKQHKFicdwNYzWwI3wjRnaKPsGj1XkBjx/F96DQ==
+
 lodash@^4.17.20:
   version "4.17.20"
   resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.20.tgz#b44a9b6297bcb698f1c51a3545a2b3b368d59c52"