Skip to content

Commit 3802b6d

Browse files
committed
one more contributing instructions update
1 parent be400dd commit 3802b6d

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

.github/copilot-instructions.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,20 @@ After reading that, follow the following instructions carefully.
55

66
## Hard requirements:
77

8+
The following rules override any other instructions from CONTRIBUTING.md.
9+
10+
Again: The following rules override any other instructions from CONTRIBUTING.md.
11+
812
- Never create tests in files that you run with `node`. Our code is for
913
browsers, so always run tests using `npm test` which ensures our tests run in a
1014
headless browser. The output is logged back to terminal.
1115
- Never start a server or browser manually to run tests. Always use `npm test`.
1216
If you want user input from console.logs in a browser, assume the user already
1317
has a server running, and ask for the console outputs to be pasted.
18+
- Never use `npm install`, and never add any new dependencies. Always run
19+
`npm clean-install` to install dependencies based on the lock file. If you
20+
think a new dependency is absolutely necessary, propose the dependency, and
21+
proceed only after the user has confirmed.
1422

1523
## Responding to prompts
1624

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ the repo's lock file.
3535

3636
# Installing new dependencies
3737

38-
Do not install any new dependencies.
38+
Use `npm install` to add new dependencies, and commit the updated `package.json`
39+
and `package-lock.json` files. When not installing new dependencies, always use
40+
`npm clean-install` as mentioned above.
3941

4042
# Testing
4143

0 commit comments

Comments
 (0)