-
Notifications
You must be signed in to change notification settings - Fork 180
Description
Hi guys, first off, this is quite an exciting project, you’re definitely on to something!
Just thought I’d flag a few build issues in the examples which I’m sure you’re aware of, but didn’t want them to go by silently.
I generally use GitHub actions to help me evaluate new repos: here are some workflow files showing builds failing:
https://github.com/lucky-tensor/luminal/tree/ci-build
https://github.com/lucky-tensor/luminal/actions/runs/17681723585#summary-50259307310

Here’s with some patches to get build working.
https://github.com/lucky-tensor/luminal/tree/dev
Also noticed you’re not using native cpu optimized builds, and there may be a good reason for that. Here’s what I’ve changed, FYI:
lucky-tensor@89000da
Note re CUDA, these could run on the gh actions runners with GPU attached, but I’ll run on self-hosted runner.
Feel free of course to PR these if you find them useful.