CI upload; seems to run twice

[Tieske]

@alerque see this https://github.com/lunarmodules/lualogging/actions/runs/4027578652/jobs/6923487713

Is there any reason this would run twice? I cannot find the job that succeeded, only the one that failed. But the error is that the rock was already there...

Any ideas?

[Tieske]

could it be related to the matrix, having an additional dimension; https://github.com/lunarmodules/lualogging/blob/master/.github/workflows/test.yml#L12 ?

[alerque]

No it has to do with the way Git pushes trigger workflow runs. The same commit was pushed twice, once as HEAD to the master branch and once as the referent of the tag:

I'll look into how to resolve that so deploys don't get triggered twice, but off the top of my head it isn't obvious how. It might be a matter of just checking whether it has run before and skipping if so.

[Tieske]

maybe force the upload? would that have negative consequences?

[alerque]

The only negatives I can think of is that the LuaRocks interface would always show "force pushed" for all releases without any good reason for that to have happened, something distro packagers at least don't like to see. Also it seems like it would be at more danger of creating race conditions than just failing like it is now if already done. I think I'd rather poke around and try to find a viable way of not running it at all.