fix(v1.2.11): bundle ffmpeg, drag window, transcript preserved on summary failure

Six accumulated fixes:

1) ffmpeg auto-bundle (zero manual setup)
   - Add imageio-ffmpeg to requirements.txt + collect_all() in spec.
   - find_ffmpeg() prefers the bundled static binary (resolved via
     imageio_ffmpeg.get_ffmpeg_exe()) over system PATH so end users don't
     need brew/choco install ffmpeg anymore.
   - Rewrite _ffprobe_duration to parse "Duration:" from ffmpeg stderr with
     early-terminate Popen (imageio-ffmpeg ships ffmpeg only, no ffprobe).
   - Cache result so audio call sites don't re-spawn.
   - Drop the now-redundant CI install/copy steps on Win/Mac/Linux that
     installed ffmpeg on the build runner.

2) Drag window
   - Add core:window:allow-start-dragging + toggle-maximize permissions to
     capabilities/default.json — they're NOT in core:default in Tauri 2.9.
     Without them startDragging() rejects silently; the click did nothing.
   - Make handleTopnavMouseDown fire-and-forget (drag-start must be called
     synchronously while OS still has mouse button held).
   - console.error with permission-hint instead of silent console.warn.

3) Upload + summary best-effort (transcript preserved on LLM failure)
   - Pipeline: pre-check llm_api_key; skip summarize with
     summary_skipped=true when missing — job still ends DONE with saved
     transcript. Summary errors also isolated in their own try/except
     so they never trash the upload pass.
   - JobState: add transcript_saved, summary_skipped, summary_skip_reason.
   - UploadAudioModal: pre-flight STT key check; recovery path when
     status=failed but transcript_saved=true; friendly "Transcript đã lưu"
     screen with hint to configure AI key in Settings.

4) Empty meeting cleanup + smart duplicate check
   - On pipeline failure or cancellation with no transcript: DELETE the
     meeting row + audio file instead of leaving it as 'failed'. Stops
     cluttering the meeting list and prevents poisoning the duplicate
     lookup for the user's next upload of the same file.
   - find_meeting_by_hash filters out empty/failed rows (transcript IS
     NULL OR empty), belt-and-suspenders for users who already have rows
     from earlier versions.

5) Realtime WS error toast
   - When openStreamingWebSocket returns null (all bases rejected), show
     a clear toast with provider name + recovery hint instead of silently
     downgrading to chunk mode.

6) Version bump 1.2.10 → 1.2.11.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: luongnd

.github/workflows/build-linux.yml

@@ -15,6 +15,9 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install system dependencies
+        # ffmpeg removed from this list (v1.2.11+): the sidecar bundles a
+        # static ffmpeg binary via imageio-ffmpeg's wheel, so the runner
+        # doesn't need its own. See src-python/services/audio.py find_ffmpeg().
         run: |
           sudo apt-get update
           sudo apt-get install -y \
@@ -23,8 +26,7 @@ jobs:
             patchelf \
             libssl-dev \
             libgtk-3-dev \
-            libayatana-appindicator3-dev \
-            ffmpeg
+            libayatana-appindicator3-dev
 
       - name: Setup Node.js
         uses: actions/setup-node@v4

.github/workflows/build-macos.yml

@@ -54,8 +54,10 @@ jobs:
       - name: Install uv
         uses: astral-sh/setup-uv@v4
 
-      - name: Install ffmpeg
-        run: brew install ffmpeg
+      # ffmpeg is bundled via imageio-ffmpeg's Python wheel (v1.2.11+), so the
+      # build runner doesn't need brew install ffmpeg anymore. The wheel ships
+      # a static macOS-aarch64 binary that PyInstaller picks up via
+      # collect_all('imageio_ffmpeg'). See src-python/services/audio.py.
 
       - name: Install Python dependencies
         working-directory: src-python

.github/workflows/build.yml

@@ -37,8 +37,10 @@ jobs:
       - name: Install uv
         uses: astral-sh/setup-uv@v4
 
-      - name: Install ffmpeg
-        run: choco install ffmpeg -y
+      # ffmpeg is bundled via imageio-ffmpeg's Python wheel (v1.2.11+), so the
+      # build runner doesn't need choco install ffmpeg anymore. The wheel ships
+      # a static ffmpeg.exe that PyInstaller picks up via
+      # collect_all('imageio_ffmpeg'). See src-python/services/audio.py.
 
       - name: Install Python dependencies
         working-directory: src-python
@@ -73,13 +75,11 @@ jobs:
           "%~dp0sidecar-dist\scribble-sidecar.exe" %*
           WINEOF
 
-      - name: Bundle ffmpeg for Windows
-        shell: bash
-        run: |
-          FFMPEG_PATH=$(which ffmpeg || echo "")
-          if [ -n "$FFMPEG_PATH" ]; then
-            cp "$FFMPEG_PATH" src-tauri/binaries/ffmpeg.exe
-          fi
+      # "Bundle ffmpeg for Windows" step removed in v1.2.11. The file was
+      # copied into src-tauri/binaries/ffmpeg.exe but never actually shipped
+      # to end users — it wasn't listed in tauri.conf.json's externalBin or
+      # resources. ffmpeg now ships inside the sidecar tarball via
+      # imageio-ffmpeg, see src-python/services/audio.py find_ffmpeg().
 
       - name: Install frontend dependencies
         run: pnpm install

package.json

@@ -1,7 +1,7 @@
 {
   "name": "voicescribe",
   "private": true,
-  "version": "1.2.10",
+  "version": "1.2.11",
   "type": "module",
   "scripts": {
     "dev": "vite",

src-python/db.py

@@ -397,12 +397,28 @@ def delete_meeting(self, mid: int):
         conn.commit()
 
     def find_meeting_by_hash(self, file_hash: str) -> int | None:
-        """Idempotency lookup for uploaded files. Returns meeting_id if exists, else None."""
+        """Idempotency lookup for uploaded files. Returns meeting_id if a
+        PREVIOUS SUCCESSFUL upload of the same file exists.
+
+        Only matches meetings that produced an actual transcript — failed /
+        empty uploads from earlier attempts must NOT block a re-upload. This
+        is belt-and-suspenders alongside the pipeline's failure-cleanup
+        (which deletes empty meeting rows when no transcript was saved);
+        we keep the filter here so users upgrading from older versions
+        aren't blocked by leftover empty rows in their existing DB.
+        """
         if not file_hash:
             return None
         conn = self._conn()
         row = conn.execute(
-            "SELECT id FROM meetings WHERE file_hash = ? LIMIT 1",
+            """
+            SELECT id FROM meetings
+            WHERE file_hash = ?
+              AND transcript IS NOT NULL
+              AND TRIM(transcript) NOT IN ('', '[]')
+            ORDER BY id DESC
+            LIMIT 1
+            """,
             (file_hash,),
         ).fetchone()
         return row["id"] if row else None

src-python/requirements.txt

@@ -11,4 +11,10 @@ requests
 soniox>=2.0.0
 python-docx>=1.1.2
 onnxruntime>=1.17.0
+# imageio-ffmpeg ships a static ffmpeg binary inside its wheel — auto-bundled
+# by PyInstaller via collect_all() in the spec. Eliminates the "brew install
+# ffmpeg" / "choco install ffmpeg" prerequisite for end users (zero manual
+# setup). ffprobe is NOT included; we parse "Duration:" from ffmpeg stderr
+# instead (see _ffprobe_duration in upload_pipeline.py).
+imageio-ffmpeg>=0.5.1
 pyinstaller>=6.0

src-python/scribble-sidecar.spec

@@ -53,6 +53,13 @@ datas += tmp_ret[0]; binaries += tmp_ret[1]; hiddenimports += tmp_ret[2]
 # fails CERTIFICATE_VERIFY_FAILED on TLS handshake to wss://stt-rt.soniox.com.
 tmp_ret = collect_all('certifi')
 datas += tmp_ret[0]; binaries += tmp_ret[1]; hiddenimports += tmp_ret[2]
+# imageio-ffmpeg bundles a static ffmpeg binary in its wheel. collect_all
+# pulls the binary file in as `datas`; at runtime find_ffmpeg() calls
+# imageio_ffmpeg.get_ffmpeg_exe() to resolve the absolute path inside the
+# PyInstaller _MEIPASS / dist directory. Zero manual setup — no more
+# "brew install ffmpeg" prerequisite for end users.
+tmp_ret = collect_all('imageio_ffmpeg')
+datas += tmp_ret[0]; binaries += tmp_ret[1]; hiddenimports += tmp_ret[2]
 
 # ── Aggressive excludes ──
 # These are transitive deps pulled in by collect_all('riva') and other packages.

src-python/services/audio.py

@@ -12,22 +12,70 @@
 log = get_logger(__name__)
 
 
+_FFMPEG_CACHE: str | None = None
+
+
 def find_ffmpeg() -> str:
-    """Find ffmpeg binary, searching common locations on macOS/Linux/Windows."""
+    """Resolve an ffmpeg binary path, preferring the bundled one.
+
+    Resolution order (first hit wins):
+      1. imageio-ffmpeg's bundled static binary — ships in the Python wheel
+         and is picked up by PyInstaller via `collect_all('imageio_ffmpeg')`.
+         This is the path end users hit in a packaged install (no homebrew /
+         choco required — zero manual setup).
+      2. ffmpeg sitting next to the sidecar executable — Windows CI copies
+         the build-host's ffmpeg.exe here as a legacy fallback.
+      3. System PATH (`shutil.which`).
+      4. Common per-OS install locations (Homebrew prefix, ProgramFiles,
+         Scoop, etc.) for dev environments that have ffmpeg installed but
+         not in the inherited PATH (Tauri-launched apps on macOS get a
+         stripped PATH that excludes /opt/homebrew/bin).
+
+    Cached after first lookup so we don't subprocess-spawn ffmpeg dozens of
+    times for the import-resolution side effect on every audio call.
+    """
+    global _FFMPEG_CACHE
+    if _FFMPEG_CACHE and os.path.isfile(_FFMPEG_CACHE):
+        return _FFMPEG_CACHE
+
     import shutil
     import sys as _sys
 
-    found = shutil.which("ffmpeg")
-    if found:
-        return found
-
-    # Check next to the running sidecar executable (PyInstaller bundle)
+    # 1. Prefer the bundled static binary from imageio-ffmpeg. This is the
+    # path that makes the app actually self-contained for end users.
+    try:
+        import imageio_ffmpeg
+        bundled = imageio_ffmpeg.get_ffmpeg_exe()
+        if bundled and os.path.isfile(bundled):
+            # Defensive: ensure exec bit (PyInstaller _MEIPASS preserves it
+            # but the static-binary may land in a tarball-extracted dir
+            # without +x on Linux).
+            if not _sys.platform == "win32":
+                try:
+                    os.chmod(bundled, 0o755)
+                except OSError:
+                    pass
+            _FFMPEG_CACHE = bundled
+            log.info("[ffmpeg] Using bundled imageio-ffmpeg binary: %s", bundled)
+            return bundled
+    except Exception as e:
+        log.warning("[ffmpeg] imageio-ffmpeg not available, falling back to system search: %s", e)
+
+    # 2. Next to the sidecar executable (CI bundling path for Windows).
     exe_dir = Path(_sys.executable).parent
     for name in ("ffmpeg.exe", "ffmpeg"):
         candidate = exe_dir / name
         if candidate.is_file():
-            return str(candidate)
+            _FFMPEG_CACHE = str(candidate)
+            return _FFMPEG_CACHE
 
+    # 3. System PATH.
+    found = shutil.which("ffmpeg")
+    if found:
+        _FFMPEG_CACHE = found
+        return found
+
+    # 4. Common install locations (dev fallback).
     if _sys.platform == "win32":
         win_candidates = [
             Path(os.environ.get("ProgramFiles", r"C:\Program Files")) / "ffmpeg" / "bin" / "ffmpeg.exe",
@@ -40,18 +88,25 @@ def find_ffmpeg() -> str:
         for c in win_candidates:
             try:
                 if c.is_file():
-                    return str(c)
+                    _FFMPEG_CACHE = str(c)
+                    return _FFMPEG_CACHE
             except Exception:
                 pass
         raise FileNotFoundError(
-            "ffmpeg not found. Install via: choco install ffmpeg  OR  "
-            "scoop install ffmpeg  OR  download from https://ffmpeg.org"
+            "ffmpeg binary not found in the app bundle (this should never happen — "
+            "imageio-ffmpeg ships it with the sidecar). Reinstall Scribble from "
+            "https://scribble-rho.vercel.app or contact support."
         )
     else:
         for candidate in ["/opt/homebrew/bin/ffmpeg", "/usr/local/bin/ffmpeg", "/usr/bin/ffmpeg"]:
             if os.path.isfile(candidate) and os.access(candidate, os.X_OK):
+                _FFMPEG_CACHE = candidate
                 return candidate
-        raise FileNotFoundError("ffmpeg not found. Install via: brew install ffmpeg")
+        raise FileNotFoundError(
+            "ffmpeg binary not found in the app bundle (this should never happen — "
+            "imageio-ffmpeg ships it with the sidecar). Reinstall Scribble from "
+            "https://scribble-rho.vercel.app or contact support."
+        )
 
 
 def transcode_audio_for_export(source: Path, fmt: str) -> Path:

src-python/services/job_registry.py

@@ -40,6 +40,16 @@ class JobState:
     error: str | None = None
     total_chunks: int = 0
     processed_chunks: int = 0
+    # Set when the LLM summarize step is intentionally skipped (no API key)
+    # or fails — the pipeline still ends in DONE with a saved transcript.
+    # Frontend uses this to show a friendly "transcript saved, configure LLM
+    # to enable auto-minutes" message instead of an error.
+    summary_skipped: bool = False
+    summary_skip_reason: str = ""
+    # True once the transcript JSON has been written to DB. Lets the UI
+    # offer "Open meeting" even if the job later ends in FAILED — so users
+    # never lose their transcript work even when a downstream step crashes.
+    transcript_saved: bool = False
     created_at: float = field(default_factory=time.time)
     updated_at: float = field(default_factory=time.time)
 
@@ -56,6 +66,9 @@ def to_dict(self) -> dict[str, Any]:
             "error": self.error,
             "total_chunks": self.total_chunks,
             "processed_chunks": self.processed_chunks,
+            "summary_skipped": self.summary_skipped,
+            "summary_skip_reason": self.summary_skip_reason,
+            "transcript_saved": self.transcript_saved,
             "created_at": self.created_at,
             "updated_at": self.updated_at,
         }