fix(sudo): check sudo command availabilty before processing

Author: lutefd

internal/app/app.go

@@ -3,6 +3,7 @@ package app
 import (
 	"fmt"
 	"os"
+	"os/exec"
 	"path/filepath"
 )
 
@@ -33,6 +34,15 @@ func NewInstaller(downloadOnly, forceInstall bool, configureSettings bool) *Inst
 	}
 }
 
+func (i *Installer) CheckSudoAccess() error {
+	cmd := exec.Command("sudo", "-n", "true")
+	cmd.Stderr = os.Stderr
+	if err := cmd.Run(); err != nil {
+		return fmt.Errorf("this installer requires sudo privileges. Please ensure you have sudo access and try again")
+	}
+	return nil
+}
+
 func (i *Installer) CheckInstallation() *InstallationStatus {
 	metadata, err := i.readMetadata()
 	if err != nil {

internal/app/metadata.go

@@ -38,20 +38,12 @@ func (i *Installer) readMetadata() (*CursorMetadata, error) {
 	tmpFile.Close()
 	defer os.Remove(tmpPath)
 
-	cmd := exec.Command("sudo", "-S", "cp", metadataPath, tmpPath)
+	cmd := exec.Command("sudo", "-S", "sh", "-c", fmt.Sprintf("cp %s %s && chmod 644 %s", metadataPath, tmpPath, tmpPath))
 	cmd.Stdin = os.Stdin
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	if err := cmd.Run(); err != nil {
-		return nil, fmt.Errorf("failed to copy metadata file (sudo error): %v", err)
-	}
-
-	cmd = exec.Command("sudo", "-S", "chmod", "644", tmpPath)
-	cmd.Stdin = os.Stdin
-	cmd.Stdout = os.Stdout
-	cmd.Stderr = os.Stderr
-	if err := cmd.Run(); err != nil {
-		return nil, fmt.Errorf("failed to set permissions on temporary file (sudo error): %v", err)
+		return nil, fmt.Errorf("failed to copy and set permissions on metadata file (sudo error): %v", err)
 	}
 
 	data, err := os.ReadFile(tmpPath)
@@ -85,20 +77,12 @@ func (i *Installer) writeMetadata(metadata *CursorMetadata) error {
 	}
 	tmpFile.Close()
 
-	cmd := exec.Command("sudo", "-S", "mv", tmpPath, metadataPath)
-	cmd.Stdin = os.Stdin
-	cmd.Stdout = os.Stdout
-	cmd.Stderr = os.Stderr
-	if err := cmd.Run(); err != nil {
-		return fmt.Errorf("failed to install metadata file (sudo error): %v", err)
-	}
-
-	cmd = exec.Command("sudo", "-S", "chmod", "644", metadataPath)
+	cmd := exec.Command("sudo", "-S", "sh", "-c", fmt.Sprintf("mv %s %s && chmod 644 %s", tmpPath, metadataPath, metadataPath))
 	cmd.Stdin = os.Stdin
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	if err := cmd.Run(); err != nil {
-		return fmt.Errorf("failed to set metadata file permissions (sudo error): %v", err)
+		return fmt.Errorf("failed to install and set permissions on metadata file (sudo error): %v", err)
 	}
 
 	return nil

internal/ui/model.go

@@ -48,6 +48,11 @@ func NewModel(downloadOnly, forceInstall bool, configureSettings bool) model {
 	}
 
 	steps := []InstallationStep{
+		{
+			name:    "Check Permissions",
+			message: "Checking sudo access...",
+			run:     installer.CheckSudoAccess,
+		},
 		{
 			name:    "Check Installation",
 			message: checkMessage,