Subdivision assigns wrong node indices in v1.0

[luukvdmeer]

In the new implementation of to_spatial_subdivision() in v1.0, it seems that updating node indices in the from and to columns of the edges table is not always done correctly. Not sure yet why, but this is a serious bug that needs to be fixed soon! Reproduce by loading the Cape Town road network from the sfnetworks workshop (https://luukvdmeer.github.io/sfnetworks-workshop/hands-on.html#cape-town-datasets), converting it into a network with as_sfnetwork(), and then calling to_spatial_subdivision() on it.

[agila5]

Hi @luukvdmeer! Do you remember what was the issue? When running the suggested code, I don't see any obvious problem:

library(sf)
#> Linking to GEOS 3.13.0, GDAL 3.10.1, PROJ 9.5.1; sf_use_s2() is TRUE
library(sfnetworks)
library(tidygraph)
#> 
#> Attaching package: 'tidygraph'
#> The following object is masked from 'package:stats':
#> 
#>     filter

ct_roads <- read_sf(
  "https://github.com/luukvdmeer/sfnetworks-workshop/raw/refs/heads/main/data/south-africa/cape-town/cape_town_osm_roads.gpkg"
) |>
  rename(geometry = geom)

sfn <- as_sfnetwork(ct_roads)
sfn |> convert(to_spatial_subdivision)
#> Warning: `subdivide_edges()` assumes all attributes are constant over geometries.
#> ! Not all attributes are labelled as being constant.
#> ℹ You can label attribute-geometry relations using `sf::st_set_agr()`.
#> # A sfnetwork: 8783 nodes and 11901 edges
#> #
#> # A directed multigraph with 98 components and spatially explicit edges
#> #
#> # Dimension: XY
#> # Bounding box: xmin: 18.39337 ymin: -33.93619 xmax: 18.47847 ymax: -33.89772
#> # Geodetic CRS: WGS 84
#> #
#> # Node data: 8,783 × 2 (active)
#>               geometry .tidygraph_node_index
#>            <POINT [°]>                 <int>
#> 1 (18.43427 -33.91962)                     1
#> 2 (18.43212 -33.91819)                     2
#> 3 (18.43305 -33.92481)                     3
#> 4 (18.42391 -33.91433)                     4
#> 5 (18.42496 -33.91403)                     5
#> 6 (18.43482 -33.92874)                     6
#> # ℹ 8,777 more rows
#> #
#> # Edge data: 11,901 × 11
#>    from    to name                  type  maxspeed surface lanes oneway cycleway
#>   <int> <int> <chr>                 <chr> <chr>    <chr>   <chr> <chr>  <chr>   
#> 1     1     2 Nelson Mandela Boule… moto… 80       asphalt 2     yes    <NA>    
#> 2     3     1 Nelson Mandela Boule… moto… 80       asphalt 2     yes    <NA>    
#> 3     4     5 Nelson Mandela Boule… prim… 60       asphalt 4     yes    <NA>    
#> # ℹ 11,898 more rows
#> # ℹ 2 more variables: geometry <LINESTRING [°]>, .tidygraph_edge_index <int>

^{Created on 2025-10-02 with reprex v2.1.1.9000}

Session info

sessioninfo::session_info()
#> Warning in system2("quarto", "-V", stdout = TRUE, env = paste0("TMPDIR=", :
#> running command '"quarto"
#> TMPDIR=C:/Users/andre/AppData/Local/Temp/RtmpE3dNAo/file506416d140f4 -V' had
#> status 1
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.4.2 (2024-10-31 ucrt)
#>  os       Windows 11 x64 (build 26100)
#>  system   x86_64, mingw32
#>  ui       RTerm
#>  language (EN)
#>  collate  Italian_Italy.utf8
#>  ctype    Italian_Italy.utf8
#>  tz       Europe/Rome
#>  date     2025-10-02
#>  pandoc   3.2 @ C:/Program Files/RStudio/resources/app/bin/quarto/bin/tools/ (via rmarkdown)
#>  quarto   NA @ C:\\Users\\andre\\AppData\\Local\\Programs\\Quarto\\bin\\quarto.exe
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package          * version    date (UTC) lib source
#>  abind              1.4-8      2024-09-12 [1] CRAN (R 4.4.2)
#>  class              7.3-22     2023-05-03 [2] CRAN (R 4.4.2)
#>  classInt           0.4-11     2025-01-08 [1] CRAN (R 4.4.2)
#>  cli                3.6.5      2025-04-23 [1] CRAN (R 4.4.2)
#>  DBI                1.2.3      2024-06-02 [1] CRAN (R 4.4.2)
#>  deldir             2.0-4      2024-02-28 [1] CRAN (R 4.4.2)
#>  dichromat          2.0-0.1    2022-05-02 [1] CRAN (R 4.4.2)
#>  digest             0.6.37     2024-08-19 [1] CRAN (R 4.4.2)
#>  dplyr              1.1.4      2023-11-17 [1] CRAN (R 4.4.2)
#>  e1071              1.7-16     2024-09-16 [1] CRAN (R 4.4.2)
#>  evaluate           1.0.3      2025-01-10 [1] CRAN (R 4.4.2)
#>  farver             2.1.2      2024-05-13 [1] CRAN (R 4.4.2)
#>  fastmap            1.2.0      2024-05-15 [1] CRAN (R 4.4.2)
#>  fs                 1.6.5      2024-10-30 [1] CRAN (R 4.4.2)
#>  generics           0.1.3      2022-07-05 [1] CRAN (R 4.4.2)
#>  ggplot2            4.0.0      2025-09-11 [1] CRAN (R 4.4.2)
#>  glue               1.8.0      2024-09-30 [1] CRAN (R 4.4.2)
#>  goftest            1.2-3      2021-10-07 [1] CRAN (R 4.4.2)
#>  gtable             0.3.6      2024-10-25 [1] CRAN (R 4.4.2)
#>  htmltools          0.5.8.1    2024-04-04 [1] CRAN (R 4.4.2)
#>  igraph             2.1.4      2025-01-23 [1] CRAN (R 4.4.2)
#>  KernSmooth         2.23-24    2024-05-17 [2] CRAN (R 4.4.2)
#>  knitr              1.50.4     2025-07-11 [1] https://yihui.r-universe.dev (R 4.4.2)
#>  lattice            0.22-6     2024-03-20 [2] CRAN (R 4.4.2)
#>  lifecycle          1.0.4      2023-11-07 [1] CRAN (R 4.4.2)
#>  lwgeom             0.2-14     2024-02-21 [1] CRAN (R 4.4.2)
#>  magrittr           2.0.3      2022-03-30 [1] CRAN (R 4.4.2)
#>  Matrix             1.7-1      2024-10-18 [2] CRAN (R 4.4.2)
#>  mgcv               1.9-3      2025-04-04 [1] CRAN (R 4.4.2)
#>  nlme               3.1-166    2024-08-14 [2] CRAN (R 4.4.2)
#>  pillar             1.10.2     2025-04-05 [1] CRAN (R 4.4.3)
#>  pkgconfig          2.0.3      2019-09-22 [1] CRAN (R 4.4.2)
#>  polyclip           1.10-7     2024-07-23 [1] CRAN (R 4.4.2)
#>  proxy              0.4-27     2022-06-09 [1] CRAN (R 4.4.2)
#>  purrr              1.0.4      2025-02-05 [1] CRAN (R 4.4.2)
#>  R6                 2.6.1      2025-02-15 [1] CRAN (R 4.4.2)
#>  RColorBrewer       1.1-3      2022-04-03 [1] CRAN (R 4.4.2)
#>  Rcpp               1.1.0      2025-07-02 [1] CRAN (R 4.4.2)
#>  reprex             2.1.1.9000 2025-02-25 [1] Github (tidyverse/reprex@07cd5d7)
#>  rlang              1.1.6      2025-04-11 [1] CRAN (R 4.4.3)
#>  rmarkdown          2.29       2024-11-04 [1] CRAN (R 4.4.2)
#>  rpart              4.1.23     2023-12-05 [2] CRAN (R 4.4.2)
#>  rstudioapi         0.17.1     2024-10-22 [1] CRAN (R 4.4.2)
#>  S7                 0.2.0      2024-11-07 [1] CRAN (R 4.4.2)
#>  scales             1.4.0      2025-04-24 [1] CRAN (R 4.4.2)
#>  sessioninfo        1.2.3      2025-02-05 [1] CRAN (R 4.4.2)
#>  sf               * 1.0-22     2025-09-10 [1] Github (r-spatial/sf@967f34b)
#>  sfheaders          0.4.4      2024-01-17 [1] CRAN (R 4.4.2)
#>  sfnetworks       * 0.9.9.9000 2025-10-02 [1] local
#>  spatstat.data      3.1-8      2025-08-24 [1] https://spatstat.r-universe.dev (R 4.4.2)
#>  spatstat.explore   3.5-2      2025-08-24 [1] https://spatstat.r-universe.dev (R 4.4.2)
#>  spatstat.geom      3.5-0.008  2025-08-19 [1] https://spatstat.r-universe.dev (R 4.4.2)
#>  spatstat.linnet    3.3-1      2025-08-24 [1] https://spatstat.r-universe.dev (R 4.4.2)
#>  spatstat.model     3.4-0.004  2025-09-01 [1] Github (spatstat/spatstat.model@873a75e)
#>  spatstat.random    3.4-1      2025-05-20 [1] CRAN (R 4.4.2)
#>  spatstat.sparse    3.1-0      2024-06-21 [1] CRAN (R 4.4.2)
#>  spatstat.univar    3.1-4      2025-07-13 [1] https://spatstat.r-universe.dev (R 4.4.2)
#>  spatstat.utils     3.1-5.001  2025-07-25 [1] https://spatstat.r-universe.dev (R 4.4.3)
#>  tensor             1.5        2012-05-05 [1] CRAN (R 4.4.2)
#>  tibble             3.2.1      2023-03-20 [1] CRAN (R 4.4.2)
#>  tidygraph        * 1.3.1      2024-01-30 [1] CRAN (R 4.4.2)
#>  tidyr              1.3.1      2024-01-24 [1] CRAN (R 4.4.2)
#>  tidyselect         1.2.1      2024-03-11 [1] CRAN (R 4.4.2)
#>  units              0.8-7.3    2025-09-08 [1] Github (r-quantities/units@bd0b33a)
#>  utf8               1.2.4      2023-10-22 [1] CRAN (R 4.4.2)
#>  vctrs              0.6.5      2023-12-01 [1] CRAN (R 4.4.2)
#>  withr              3.0.2      2024-10-28 [1] CRAN (R 4.4.2)
#>  xfun               0.52       2025-04-02 [1] CRAN (R 4.4.2)
#>  yaml               2.3.10     2024-07-26 [1] CRAN (R 4.4.2)
#> 
#>  [1] C:/Users/andre/AppData/Local/R/win-library/4.4
#>  [2] C:/Program Files/R/R-4.4.2/library
#>  * ── Packages attached to the search path.
#> 
#> ──────────────────────────────────────────────────────────────────────────────