fix: handle return value of uv_pipe_connect2

The missing check meant that no error was propagated when it returned UV_EINVAL.
This notably produced no error when specifying an invalid name, and made
specifying UV_PIPE_NO_TRUNCATE ineffective.

This was likely missed out because libuv's documented return value for
uv_pipe_connect2 incorrectly stated that it returns void, not int; that's since
been fixed.

Author: seandewar

src/pipe.c

@@ -98,7 +98,12 @@ static int luv_pipe_connect2(lua_State* L) {
   int ref = luv_check_continuation(L, 4);
   uv_connect_t* req = (uv_connect_t*)lua_newuserdata(L, uv_req_size(UV_CONNECT));
   req->data = luv_setup_req(L, ctx, ref);
-  uv_pipe_connect2(req, handle, name, namelen, flags, luv_connect_cb);
+  int ret = uv_pipe_connect2(req, handle, name, namelen, flags, luv_connect_cb);
+  if (ret < 0) {
+    luv_cleanup_req(L, (luv_req_t*)req->data);
+    lua_pop(L, 1);
+    return luv_error(L, ret);
+  }
   return 1;
 }
 #endif

tests/test-pipe.lua

@@ -155,4 +155,17 @@ return require('lib/tap')(function (test)
     end
   end, "1.46.0")
 
+  test("pipe connect2 error", function (print, p, expect, uv)
+    local pipe = assert(uv.new_pipe(false))
+
+    local ran_cb = false
+    local _, err = pipe:connect2("", nil, function()
+      ran_cb = true
+    end)
+    assert(err:match("^EINVAL:"))
+    uv.run()
+    assert(not ran_cb)
+
+    pipe:close()
+  end, "1.46.0")
 end)