Skip to content

Commit 843461d

Browse files
committed
Fixed duplicate entry in Add/Remove programs after upgrade
1 parent d4f69a4 commit 843461d

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

Installer/Product.wxs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
<?define _TargetDir=$(var.SoliditySHA3MinerUI.TargetDir)?>
66
<?define _UpgradeCode="220cd27c-38e1-4360-a113-243b4de4028f"?>
77
<?define _ProductVersion="!(bind.FileVersion.SoliditySHA3MinerUI.exe)"?>
8-
<?define _InstallerVersion="1.0.0"?><!--Changing installer version will trigger deletion method in InstallerHelper-->
98

109
<Product Id="*"
11-
Name="SoliditySHA3Miner GUI v$(var._ProductVersion)"
12-
Version="$(var._InstallerVersion)"
10+
Name="SoliditySHA3Miner GUI"
11+
Version="$(var._ProductVersion)"
1312
Manufacturer="lwYeo@github"
1413
UpgradeCode="$(var._UpgradeCode)"
1514
Language="1033">
@@ -34,7 +33,7 @@
3433
<UpgradeVersion OnlyDetect="yes"
3534
IncludeMinimum="no"
3635
IncludeMaximum="no"
37-
Maximum="$(var._InstallerVersion)"
36+
Maximum="$(var._ProductVersion)"
3837
Property="PREVIOUSFOUND" />
3938
</Upgrade>
4039

@@ -52,7 +51,9 @@
5251
DllEntry="DeleteLocalAppDir" Return="check" Execute="immediate"/>
5352

5453
<InstallExecuteSequence>
55-
<Custom Action="InstallerHelper" Before="InstallFinalize" />
54+
<Custom Action="InstallerHelper" Before="InstallFinalize">
55+
Installed AND (NOT REINSTALL) AND (NOT UPGRADINGPRODUCTCODE) AND (REMOVE="ALL")
56+
</Custom>
5657
</InstallExecuteSequence>
5758

5859
<Feature Id="ProductFeature"

0 commit comments

Comments
 (0)