@@ -137,139 +137,139 @@ jobs:
137137 env_name : ${{ needs.checkout_and_config.outputs.env_name_train }}
138138 env_path : ${{ needs.checkout_and_config.outputs.env_path }}
139139
140- functional_tests_hetero_train :
141- needs :
142- - checkout_and_config
143- - unit_tests
144- if : fromJson(needs.checkout_and_config.outputs.hetero_train_test_matrix)[0] != null
145- uses : ./.github/workflows/functional_tests_hetero_train.yml
146- with :
147- platform : ${{ inputs.platform }}
148- test_matrix : ${{ needs.checkout_and_config.outputs.hetero_train_test_matrix }}
149- image : ${{ needs.checkout_and_config.outputs.ci_train_image }}
150- runs_on : ${{ needs.checkout_and_config.outputs.runs_on }}
151- container_volumes : ${{ needs.checkout_and_config.outputs.container_volumes }}
152- container_options : ${{ needs.checkout_and_config.outputs.container_options }}
153- source_artifact : flagscale-source-${{ github.sha }}
154- pkg_mgr : ${{ needs.checkout_and_config.outputs.pkg_mgr }}
155- env_name : ${{ needs.checkout_and_config.outputs.env_name_train }}
156- env_path : ${{ needs.checkout_and_config.outputs.env_path }}
157-
158- # NOTE: Inference, serve, and rl functional tests are temporarily disabled
159- functional_tests_inference :
160- needs :
161- - checkout_and_config
162- - unit_tests
163- if : fromJson(needs.checkout_and_config.outputs.inference_test_matrix)[0] != null
164- uses : ./.github/workflows/functional_tests_inference.yml
165- with :
166- platform : ${{ inputs.platform }}
167- test_matrix : ${{ needs.checkout_and_config.outputs.inference_test_matrix }}
168- image : ${{ needs.checkout_and_config.outputs.ci_inference_image }}
169- runs_on : ${{ needs.checkout_and_config.outputs.runs_on }}
170- container_volumes : ${{ needs.checkout_and_config.outputs.container_volumes }}
171- container_options : ${{ needs.checkout_and_config.outputs.container_options }}
172- source_artifact : flagscale-source-${{ github.sha }}
173- pkg_mgr : ${{ needs.checkout_and_config.outputs.pkg_mgr }}
174- env_name : ${{ needs.checkout_and_config.outputs.env_name_inference }}
175- env_path : ${{ needs.checkout_and_config.outputs.env_path }}
140+ # functional_tests_hetero_train:
141+ # needs:
142+ # - checkout_and_config
143+ # - unit_tests
144+ # if: fromJson(needs.checkout_and_config.outputs.hetero_train_test_matrix)[0] != null
145+ # uses: ./.github/workflows/functional_tests_hetero_train.yml
146+ # with:
147+ # platform: ${{ inputs.platform }}
148+ # test_matrix: ${{ needs.checkout_and_config.outputs.hetero_train_test_matrix }}
149+ # image: ${{ needs.checkout_and_config.outputs.ci_train_image }}
150+ # runs_on: ${{ needs.checkout_and_config.outputs.runs_on }}
151+ # container_volumes: ${{ needs.checkout_and_config.outputs.container_volumes }}
152+ # container_options: ${{ needs.checkout_and_config.outputs.container_options }}
153+ # source_artifact: flagscale-source-${{ github.sha }}
154+ # pkg_mgr: ${{ needs.checkout_and_config.outputs.pkg_mgr }}
155+ # env_name: ${{ needs.checkout_and_config.outputs.env_name_train }}
156+ # env_path: ${{ needs.checkout_and_config.outputs.env_path }}
176157
177- functional_tests_serve :
178- needs :
179- - checkout_and_config
180- - unit_tests
181- if : fromJson(needs.checkout_and_config.outputs.serve_test_matrix)[0] != null
182- uses : ./.github/workflows/functional_tests_serve.yml
183- with :
184- platform : ${{ inputs.platform }}
185- test_matrix : ${{ needs.checkout_and_config.outputs.serve_test_matrix }}
186- image : ${{ needs.checkout_and_config.outputs.ci_inference_image }}
187- runs_on : ${{ needs.checkout_and_config.outputs.runs_on }}
188- container_volumes : ${{ needs.checkout_and_config.outputs.container_volumes }}
189- container_options : ${{ needs.checkout_and_config.outputs.container_options }}
190- source_artifact : flagscale-source-${{ github.sha }}
191- pkg_mgr : ${{ needs.checkout_and_config.outputs.pkg_mgr }}
192- env_name : ${{ needs.checkout_and_config.outputs.env_name_serve }}
193- env_path : ${{ needs.checkout_and_config.outputs.env_path }}
158+ # # NOTE: Inference, serve, and rl functional tests are temporarily disabled
159+ # functional_tests_inference:
160+ # needs:
161+ # - checkout_and_config
162+ # - unit_tests
163+ # if: fromJson(needs.checkout_and_config.outputs.inference_test_matrix)[0] != null
164+ # uses: ./.github/workflows/functional_tests_inference.yml
165+ # with:
166+ # platform: ${{ inputs.platform }}
167+ # test_matrix: ${{ needs.checkout_and_config.outputs.inference_test_matrix }}
168+ # image: ${{ needs.checkout_and_config.outputs.ci_inference_image }}
169+ # runs_on: ${{ needs.checkout_and_config.outputs.runs_on }}
170+ # container_volumes: ${{ needs.checkout_and_config.outputs.container_volumes }}
171+ # container_options: ${{ needs.checkout_and_config.outputs.container_options }}
172+ # source_artifact: flagscale-source-${{ github.sha }}
173+ # pkg_mgr: ${{ needs.checkout_and_config.outputs.pkg_mgr }}
174+ # env_name: ${{ needs.checkout_and_config.outputs.env_name_inference }}
175+ # env_path: ${{ needs.checkout_and_config.outputs.env_path }}
194176
195- # functional_tests_rl :
177+ # functional_tests_serve :
196178 # needs:
197179 # - checkout_and_config
198180 # - unit_tests
199- # if: fromJson(needs.checkout_and_config.outputs.rl_test_matrix )[0] != null
200- # uses: ./.github/workflows/functional_tests_rl .yml
181+ # if: fromJson(needs.checkout_and_config.outputs.serve_test_matrix )[0] != null
182+ # uses: ./.github/workflows/functional_tests_serve .yml
201183 # with:
202184 # platform: ${{ inputs.platform }}
203- # test_matrix: ${{ needs.checkout_and_config.outputs.rl_test_matrix }}
204- # image: ${{ needs.checkout_and_config.outputs.ci_image }}
185+ # test_matrix: ${{ needs.checkout_and_config.outputs.serve_test_matrix }}
186+ # image: ${{ needs.checkout_and_config.outputs.ci_inference_image }}
205187 # runs_on: ${{ needs.checkout_and_config.outputs.runs_on }}
206188 # container_volumes: ${{ needs.checkout_and_config.outputs.container_volumes }}
207189 # container_options: ${{ needs.checkout_and_config.outputs.container_options }}
208190 # source_artifact: flagscale-source-${{ github.sha }}
209191 # pkg_mgr: ${{ needs.checkout_and_config.outputs.pkg_mgr }}
210- # env_name: ${{ needs.checkout_and_config.outputs.env_name_rl }}
192+ # env_name: ${{ needs.checkout_and_config.outputs.env_name_serve }}
211193 # env_path: ${{ needs.checkout_and_config.outputs.env_path }}
212194
213- all_tests_complete :
214- defaults :
215- run :
216- shell : bash
217- needs :
218- - checkout_and_config
219- - unit_tests
220- - functional_tests_train
221- - functional_tests_hetero_train
222- # NOTE: Disabled tests removed from needs
223- # - functional_tests_inference
224- # - functional_tests_serve
225- # - functional_tests_rl
226- runs-on : ubuntu-latest
227- if : always()
228- steps :
229- - name : Verify all tests passed
230- run : |
231- # Check all test jobs (skip if not run)
232- failed=false
195+ # # functional_tests_rl:
196+ # # needs:
197+ # # - checkout_and_config
198+ # # - unit_tests
199+ # # if: fromJson(needs.checkout_and_config.outputs.rl_test_matrix)[0] != null
200+ # # uses: ./.github/workflows/functional_tests_rl.yml
201+ # # with:
202+ # # platform: ${{ inputs.platform }}
203+ # # test_matrix: ${{ needs.checkout_and_config.outputs.rl_test_matrix }}
204+ # # image: ${{ needs.checkout_and_config.outputs.ci_image }}
205+ # # runs_on: ${{ needs.checkout_and_config.outputs.runs_on }}
206+ # # container_volumes: ${{ needs.checkout_and_config.outputs.container_volumes }}
207+ # # container_options: ${{ needs.checkout_and_config.outputs.container_options }}
208+ # # source_artifact: flagscale-source-${{ github.sha }}
209+ # # pkg_mgr: ${{ needs.checkout_and_config.outputs.pkg_mgr }}
210+ # # env_name: ${{ needs.checkout_and_config.outputs.env_name_rl }}
211+ # # env_path: ${{ needs.checkout_and_config.outputs.env_path }}
233212
234- if [ "${{ needs.unit_tests.result }}" != "success" ]; then
235- echo "❌ Unit tests failed"
236- failed=true
237- fi
213+ # all_tests_complete:
214+ # defaults:
215+ # run:
216+ # shell: bash
217+ # needs:
218+ # - checkout_and_config
219+ # - unit_tests
220+ # - functional_tests_train
221+ # - functional_tests_hetero_train
222+ # # NOTE: Disabled tests removed from needs
223+ # # - functional_tests_inference
224+ # # - functional_tests_serve
225+ # # - functional_tests_rl
226+ # runs-on: ubuntu-latest
227+ # if: always()
228+ # steps:
229+ # - name: Verify all tests passed
230+ # run: |
231+ # # Check all test jobs (skip if not run)
232+ # failed=false
238233
239- # Only check functional tests if they ran
240- if [ "${{ needs.functional_tests_train.result }}" != "success" ] && \
241- [ "${{ needs.functional_tests_train.result }}" != "skipped" ]; then
242- echo "❌ Training functional tests failed"
243- failed=true
244- fi
234+ # if [ "${{ needs.unit_tests.result }}" != "success" ]; then
235+ # echo "❌ Unit tests failed"
236+ # failed=true
237+ # fi
245238
246- if [ "${{ needs.functional_tests_hetero_train.result }}" != "success" ] && \
247- [ "${{ needs.functional_tests_hetero_train.result }}" != "skipped" ]; then
248- echo "❌ Heterogeneous training functional tests failed"
249- failed=true
250- fi
239+ # # Only check functional tests if they ran
240+ # if [ "${{ needs.functional_tests_train.result }}" != "success" ] && \
241+ # [ "${{ needs.functional_tests_train.result }}" != "skipped" ]; then
242+ # echo "❌ Training functional tests failed"
243+ # failed=true
244+ # fi
251245
252- # NOTE: Inference, serve, and rl checks disabled
253- # if [ "${{ needs.functional_tests_inference.result }}" != "success" ] && \
254- # [ "${{ needs.functional_tests_inference.result }}" != "skipped" ]; then
255- # echo "❌ Inference functional tests failed"
256- # failed=true
257- # fi
246+ # if [ "${{ needs.functional_tests_hetero_train.result }}" != "success" ] && \
247+ # [ "${{ needs.functional_tests_hetero_train.result }}" != "skipped" ]; then
248+ # echo "❌ Heterogeneous training functional tests failed"
249+ # failed=true
250+ # fi
258251
259- # if [ "${{ needs.functional_tests_serve.result }}" != "success" ] && \
260- # [ "${{ needs.functional_tests_serve.result }}" != "skipped" ]; then
261- # echo "❌ Serve functional tests failed"
262- # failed=true
263- # fi
252+ # # NOTE: Inference, serve, and rl checks disabled
253+ # # if [ "${{ needs.functional_tests_inference.result }}" != "success" ] && \
254+ # # [ "${{ needs.functional_tests_inference.result }}" != "skipped" ]; then
255+ # # echo "❌ Inference functional tests failed"
256+ # # failed=true
257+ # # fi
264258
265- # if [ "${{ needs.functional_tests_rl .result }}" != "success" ] && \
266- # [ "${{ needs.functional_tests_rl .result }}" != "skipped" ]; then
267- # echo "❌ RL functional tests failed"
268- # failed=true
269- # fi
259+ # # if [ "${{ needs.functional_tests_serve .result }}" != "success" ] && \
260+ # # [ "${{ needs.functional_tests_serve .result }}" != "skipped" ]; then
261+ # # echo "❌ Serve functional tests failed"
262+ # # failed=true
263+ # # fi
270264
271- if [ "$failed" = "true" ]; then
272- exit 1
273- fi
265+ # # if [ "${{ needs.functional_tests_rl.result }}" != "success" ] && \
266+ # # [ "${{ needs.functional_tests_rl.result }}" != "skipped" ]; then
267+ # # echo "❌ RL functional tests failed"
268+ # # failed=true
269+ # # fi
270+
271+ # if [ "$failed" = "true" ]; then
272+ # exit 1
273+ # fi
274274
275- echo "✅ All tests completed successfully!"
275+ # echo "✅ All tests completed successfully!"
0 commit comments