Skip to content

Commit 96f70c6

Browse files
authored
Add react app env (#38)
1 parent c9e40d2 commit 96f70c6

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/pipeline.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
- name: Build and push
9191
env:
9292
HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
93-
run: heroku container:push -a instaclone web
93+
run: heroku container:push web -a instaclone --arg REACT_APP_SOCKET_URL=${{ secrets.REACT_APP_SOCKET_URL }}
9494
- name: Release
9595
env:
9696
HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}

Dockerfile

+4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
FROM node:20 as build-stage
44
WORKDIR /app
55

6+
ARG REACT_APP_SOCKET_URL
7+
8+
ENV REACT_APP_SOCKET_URL=$REACT_APP_SOCKET_URL
9+
610
# copying the all the frontend and backend code
711
COPY frontend ./frontend
812
COPY backend ./backend

0 commit comments

Comments
 (0)