Commit 5ae8e21
[Feature][DevTool] Add global memory usage CDP plumbing
Add the first part of the global memory query pipeline for DevTool. The commit registers Memory.getAllMemoryUsage in the Memory domain and routes both global and instance dispatch through LynxGlobalDevToolMediator.
The mediator validates the optional timeoutMs parameter, treats missing or zero timeoutMs values as the default wait policy, rejects negative values, rejects values outside the int64 and five-minute bounds, forwards accepted requests to GlobalDevToolPlatformFacade, and keeps CDP envelope construction in one place.
Introduce a move-only MemoryUsageCallback for the facade and embedder hook because the platform completion is request-scoped and consumed once. GlobalDevToolPlatformFacade now provides a default unsupported response for source compatibility with out-of-tree facade implementations, while Android, Darwin, and generic embedder fallbacks return an empty JSON result object together with an explicit unsupported-bridge error.
Add focused InspectorMemoryAgent coverage for successful platform results, invalid params, invalid timeoutMs values, default timeout normalization, negative timeout rejection, oversized timeout rejection, uint64 overflow rejection, platform error forwarding, malformed platform JSON, and unknown Memory methods. Move the test facade GetInstance implementation into the mock .cc file so the non-inline singleton override is defined once across DevTool test translation units. The Memory-agent tests use a test-local condition-variable backed MessageSender and explicitly initialize the UIThread runner before constructing the global mediator, so task-runner message delivery cannot race with assertions, time out on delivered messages with empty payloads, or block waiting for UIThread initialization without changing shared DevTool test mocks.
AutoSubmit: true1 parent 9b67fcf commit 5ae8e21
15 files changed
Lines changed: 539 additions & 7 deletions
File tree
- devtool
- embedder/core
- lynx_devtool
- agent
- android
- domain_agent
- testing
- agent
- mock
- platform/darwin/ios/lynx_devtool
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
26 | 35 | | |
27 | 36 | | |
28 | 37 | | |
| |||
50 | 59 | | |
51 | 60 | | |
52 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
53 | 79 | | |
54 | 80 | | |
55 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
| 13 | + | |
11 | 14 | | |
12 | 15 | | |
13 | 16 | | |
| |||
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
22 | 29 | | |
23 | 30 | | |
24 | 31 | | |
| |||
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
| |||
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
| |||
41 | 48 | | |
42 | 49 | | |
43 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
44 | 63 | | |
45 | 64 | | |
46 | 65 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| 22 | + | |
| 23 | + | |
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
29 | 37 | | |
30 | 38 | | |
31 | 39 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
| |||
0 commit comments