Skip to content

Commit bc9d6ab

Browse files
zsy-jasondeanjingshui
authored andcommitted
[Infra] use 15.6.1 macos runners and remove bundler
1. use the 15.6.1 macos with Xcode26.3 2. Since using CocoaPods via Bundler tends to cause inconsistent issues across different environments, we will no longer use Bundler and instead rely directly on the globally installed CocoaPods.
1 parent 24d95a9 commit bc9d6ab

12 files changed

Lines changed: 66 additions & 145 deletions

File tree

.github/actions/clay-macos-build/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ runs:
1414
run: |-
1515
cd $GITHUB_WORKSPACE/lynx
1616
source tools/envsetup.sh
17-
buildtools/gn/gn gen out/Default --args='enable_clay_standalone = true disable_visibility_hidden = true use_ndk_static_cxx = false enable_linker_map = false enable_clay = true is_headless = true skia_enable_flutter_defines = true skia_use_dng_sdk = false skia_use_sfntly = false skia_enable_pdf = false skia_enable_svg = true enable_svg = true skia_enable_skottie = true skia_use_x11 = false skia_use_wuffs = true skia_use_expat = true skia_use_fontconfig = false clay_enable_skshaper = true skia_use_icu = true skia_gl_standard = "" allow_deprecated_api_calls = true stripped_symbols = true is_official_build = true is_debug = false use_clang_static_analyzer = false enable_lto = false' --export-compile-commands
17+
buildtools/gn/gn gen out/Default --args='enable_clay_standalone = true disable_visibility_hidden = true use_ndk_static_cxx = false enable_linker_map = false enable_clay = true is_headless = true skia_enable_flutter_defines = true skia_use_dng_sdk = false skia_use_sfntly = false skia_enable_pdf = false skia_enable_svg = true enable_svg = true skia_enable_skottie = true skia_use_x11 = false skia_use_wuffs = true skia_use_expat = true skia_use_fontconfig = false clay_enable_skshaper = true skia_use_icu = true skia_gl_standard = "" allow_deprecated_api_calls = true stripped_symbols = true is_official_build = true is_debug = false use_clang_static_analyzer = false enable_lto = false use_flutter_cxx = false' --export-compile-commands
1818
buildtools/ninja/ninja -C out/Default clay/example/glfw

.github/actions/common-deps/action.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ runs:
3030
id: hab
3131
shell: bash
3232
run: |
33+
which python3
3334
if [[ "${{ inputs.target }}" == "" ]]; then
3435
python3 lynx/tools/ci/habitat_cache_helper.py
3536
else
@@ -87,6 +88,7 @@ runs:
8788
timeout_minutes: 20
8889
command: |
8990
set -e
91+
which python3
9092
if [ "$RUNNER_OS" == "macOS" ]; then
9193
python3 -m pip install -r lynx/tools/vpython_tools/requirements.txt --break-system-packages --retries 10 --timeout 60
9294
python3 -m pip install -r lynx/testing/integration_test/test_script/requirements.txt --break-system-packages --retries 10 --timeout 60

.github/actions/ios-explorer-build/action.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ runs:
1818
uses: ./lynx/.github/actions/common-deps
1919
- name: Setup Ruby Cache
2020
uses: ./lynx/.github/actions/ios-common-deps
21+
- name: Setup CocoaPods
22+
shell: bash
23+
run: |
24+
brew install cocoapods
25+
pod --version
2126
- name: Install iOS Dependencies
2227
uses: nick-fields/retry@v2
2328
with:
@@ -29,6 +34,8 @@ runs:
2934
source tools/envsetup.sh
3035
pushd explorer/darwin/ios/lynx_explorer
3136
git config --global url."https://github.com/".insteadOf "git@github.com:"
37+
export GEM_HOME="$RUNNER_TEMP/cocoapods/ruby/$(ruby -e 'puts RbConfig::CONFIG["ruby_version"]')"
38+
export PATH="$RUNNER_TEMP/cocoapods/ruby/$(ruby -e 'puts RbConfig::CONFIG["ruby_version"]')/bin:$PATH"
3239
bash bundle_install.sh ${{ inputs.build-params }}
3340
popd
3441
- name: Build Explorer App

.github/workflows/ci.yml

Lines changed: 48 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,43 @@ jobs:
6767
6868
darwin-native-unittests-check:
6969
timeout-minutes: 60
70-
runs-on: lynx-darwin-14-medium
70+
runs-on: lynx-darwin-15.6.1-medium
7171
steps:
7272
- name: Download Source
7373
uses: actions/checkout@v6
7474
with:
7575
path: lynx
76+
- name: check python version
77+
run: |
78+
python3 --version
79+
which python3
7680
- name: Install Common Dependencies
7781
uses: ./lynx/.github/actions/common-deps
7882
- name: Run Unittests
7983
run: |
8084
set -e
8185
source tools/envsetup.sh
82-
tools/rtf/rtf native-ut run --names lynx
86+
tools/rtf/rtf native-ut run --names lynx --disable-flutter-cxx
87+
88+
darwin-native-unittests-check-old:
89+
timeout-minutes: 60
90+
runs-on: lynx-darwin-14-medium
91+
steps:
92+
- name: Download Source
93+
uses: actions/checkout@v4.2.2
94+
with:
95+
path: lynx
96+
- name: check python version
97+
run: |
98+
python3 --version
99+
which python3
100+
- name: Install Common Dependencies
101+
uses: ./lynx/.github/actions/common-deps
102+
- name: Run Unittests
103+
run: |
104+
set -e
105+
source tools/envsetup.sh
106+
tools/rtf/rtf native-ut run --names lynx --disable-flutter-cxx
83107
84108
linux-native-unittests-check:
85109
runs-on: lynx-ubuntu-22.04-large
@@ -123,7 +147,7 @@ jobs:
123147
124148
ios-unittests-check:
125149
timeout-minutes: 60
126-
runs-on: lynx-darwin-14-medium
150+
runs-on: lynx-darwin-15.6.1-medium
127151
steps:
128152
- name: Download Source
129153
uses: actions/checkout@v6
@@ -135,6 +159,10 @@ jobs:
135159
uses: ./lynx/.github/actions/ios-common-deps
136160
with:
137161
cache-backend: 'lynx-infra'
162+
- name: Setup CocoaPods
163+
shell: bash
164+
run: |
165+
brew install cocoapods
138166
- name: Install iOS Dependencies
139167
uses: nick-fields/retry@v2
140168
with:
@@ -156,9 +184,12 @@ jobs:
156184
xcodebuild -showsdks | grep -Eo -m 1 "iphonesimulator([0-9]{1,}\.)+[0-9]{1,}" > sdk.txt
157185
sdkVersion=$(awk '{ sub(/iphonesimulator/,""); print $0 }' sdk.txt)
158186
echo $sdkVersion > sdk.txt
159-
xcodebuild build-for-testing ARCHS=arm64 -workspace LynxExplorer.xcworkspace -scheme LynxExplorerTests -enableCodeCoverage YES -configuration Debug -sdk iphonesimulator$(cat sdk.txt) COMPILER_INDEX_STORE_ENABLE=NO -derivedDataPath iOSCoreBuild/DerivedData -dest"platform=iOS Simulator,OS=$(cat sdk.txt),name=iPhone 11" SYMROOT=`pwd`/Build/Products -testPlan UTTest
187+
cat sdk.txt
188+
SIMULATOR_ID=$(xcrun simctl list devices | grep -E "iPhone" | grep -v "unavailable" | head -1 | grep -Eo "[0-9A-F-]{36}")
189+
echo "Using simulator ID: $SIMULATOR_ID"
190+
xcodebuild build-for-testing ARCHS=arm64 -workspace LynxExplorer.xcworkspace -scheme LynxExplorerTests -enableCodeCoverage YES -configuration Debug -sdk iphonesimulator$(cat sdk.txt) COMPILER_INDEX_STORE_ENABLE=NO -derivedDataPath iOSCoreBuild/DerivedData -destination "platform=iOS Simulator,id=$SIMULATOR_ID" SYMROOT=`pwd`/Build/Products -testPlan UTTest
160191
chmod u+x xctestrunner
161-
./xctestrunner --xctestrun `pwd`/Build/Products/LynxExplorerTests_UTTest_iphonesimulator$(cat sdk.txt)-arm64.xctestrun --work_dir `pwd` --output_dir `pwd`/iOSCoreBuild/DerivedData simulator_test
192+
./xctestrunner --xctestrun `pwd`/Build/Products/LynxExplorerTests_UTTest_iphonesimulator$(cat sdk.txt)-arm64.xctestrun --work_dir `pwd` --output_dir `pwd`/iOSCoreBuild/DerivedData test --id $SIMULATOR_ID --platform ios_simulator
162193
popd
163194
164195
cocoapods-lynx-library-build:
@@ -220,7 +251,7 @@ jobs:
220251
221252
tasm-darwin-build:
222253
timeout-minutes: 60
223-
runs-on: lynx-darwin-14-medium
254+
runs-on: lynx-darwin-15.6.1-medium
224255
steps:
225256
- name: Download Source
226257
uses: actions/checkout@v6
@@ -243,7 +274,7 @@ jobs:
243274
244275
tasm-wasm-build:
245276
timeout-minutes: 60
246-
runs-on: lynx-darwin-14-medium
277+
runs-on: lynx-darwin-15.6.1-medium
247278
steps:
248279
- name: Download Source
249280
uses: actions/checkout@v6
@@ -648,7 +679,7 @@ jobs:
648679

649680
ios-explorer-build:
650681
timeout-minutes: 60
651-
runs-on: lynx-darwin-14-medium
682+
runs-on: lynx-darwin-15.6.1-medium
652683
strategy:
653684
matrix:
654685
arch: [arm64, x86_64]
@@ -671,7 +702,7 @@ jobs:
671702

672703
ios-integration-test:
673704
timeout-minutes: 15
674-
runs-on: lynx-darwin-14-medium
705+
runs-on: lynx-darwin-15.6.1-medium
675706
env:
676707
LOCAL_POD_NAME: 'local_pod'
677708
POD_VERSION: '0.0.1-alpha.1'
@@ -715,8 +746,8 @@ jobs:
715746
python3 lynx/tools/ios_tools/process_podfile.py --action insert_pod_source --podfile demo/ios/HelloLynxObjc/Podfile --pod_source "file://$GITHUB_WORKSPACE/lynx/$LOCAL_POD_NAME"
716747
cd demo/ios/HelloLynxObjc
717748
export LANG=en_US.UTF-8
718-
BUNDLE_GEMFILE=$GITHUB_WORKSPACE/lynx/Gemfile bundle --version
719-
BUNDLE_GEMFILE=$GITHUB_WORKSPACE/lynx/Gemfile bundle exec pod install
749+
brew install cocoapods
750+
pod install
720751
xcodebuild -workspace Hello-Lynx-OC.xcworkspace/ -scheme Hello-Lynx-OC CODE_SIGNING_ALLOWED=NO build
721752
722753
ios-e2e-test:
@@ -725,7 +756,7 @@ jobs:
725756
env:
726757
APPIUM_TEST_SERVER_PORT: 4723
727758
APPIUM_TEST_SERVER_HOST: 127.0.0.1
728-
runs-on: lynx-darwin-14-medium
759+
runs-on: lynx-darwin-15.6.1-medium
729760
steps:
730761
- name: Download Source
731762
uses: actions/checkout@v6
@@ -757,16 +788,16 @@ jobs:
757788
-configuration Release \
758789
-sdk iphonesimulator${{ env.SDK_VERSION }} \
759790
-derivedDataPath ./WebDriverAgent/DerivedData \
760-
-destination "platform=iOS Simulator,OS=${{ env.SDK_VERSION }},name=iPhone 15" \
791+
-destination "platform=iOS Simulator,OS=${{ env.SDK_VERSION }},name=iPhone 17" \
761792
SYMROOT=$GITHUB_WORKSPACE/Build/Products
762793
popd
763794
- name: Start iOS Simulator
764795
run: |
765-
xcrun simctl boot "iPhone 15"
796+
xcrun simctl boot "iPhone 17"
766797
- name: Install WebDriverAgent to Simulator
767798
run: |
768799
set -e
769-
SIMULATOR_UDID=$(xcrun simctl list devices "iOS ${{ env.SDK_VERSION }}" | grep "iPhone 15 (" | grep -oE '[0-9A-F-]{36}')
800+
SIMULATOR_UDID=$(xcrun simctl list devices "iOS ${{ env.SDK_VERSION }}" | grep "iPhone 17 (" | grep -oE '[0-9A-F-]{36}')
770801
echo "SIMULATOR_UDID=$SIMULATOR_UDID" >> $GITHUB_ENV
771802
xcrun simctl install $SIMULATOR_UDID \
772803
$GITHUB_WORKSPACE/Build/Products/Release-iphonesimulator/WebDriverAgentRunner-Runner.app
@@ -896,7 +927,7 @@ jobs:
896927

897928
clay-macos-build:
898929
timeout-minutes: 60
899-
runs-on: lynx-darwin-14-medium
930+
runs-on: lynx-darwin-15.6.1-medium
900931
steps:
901932
- name: Download Source
902933
uses: actions/checkout@v6
@@ -912,7 +943,7 @@ jobs:
912943

913944
macos-explorer-build:
914945
timeout-minutes: 60
915-
runs-on: lynx-darwin-14-medium
946+
runs-on: lynx-darwin-15.6.1-medium
916947
strategy:
917948
matrix:
918949
arch: [arm64, x64]

.github/workflows/cocoapods_token_keepalive.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
workflow_dispatch:
77
jobs:
88
token-keepalive:
9-
runs-on: lynx-darwin-14-medium
9+
runs-on: lynx-darwin-15.6.1-medium
1010
env:
1111
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}
1212
steps:

.github/workflows/publish-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ jobs:
177177

178178
ios-explorer-build:
179179
timeout-minutes: 60
180-
runs-on: lynx-darwin-14-medium
180+
runs-on: lynx-darwin-15.6.1-medium
181181
needs: get-version
182182
if: ${{ !contains(needs.get-version.outputs.version, '-nightly.') }}
183183
strategy:
@@ -491,7 +491,7 @@ jobs:
491491
492492
macos-explorer-release:
493493
timeout-minutes: 60
494-
runs-on: lynx-darwin-14-medium
494+
runs-on: lynx-darwin-15.6.1-medium
495495
needs: get-version
496496
if: ${{ !contains(needs.get-version.outputs.version, '-nightly.') }}
497497
strategy:

Gemfile

Lines changed: 0 additions & 3 deletions
This file was deleted.

Gemfile.lock

Lines changed: 0 additions & 108 deletions
This file was deleted.

dependencies/DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ deps = {
376376
"./tools_shared": {
377377
"type": "git",
378378
"url": "https://github.com/lynx-family/tools-shared.git",
379-
"commit": "2d6bd311f2ad10a3e17ddde395adbc7fc1fffb59",
379+
"commit": "a650d5133ce331e4303c2d01805936cf08aef05e",
380380
"ignore_in_git": True,
381381
},
382382
'buildtools/doxygen': {

dependencies/DEPS.tools_shared

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ deps = {
77
"./tools_shared": {
88
"type": "git",
99
"url": "https://github.com/lynx-family/tools-shared.git",
10-
"commit": "a1f5807a5e89b52d4c015a946371bd29730a31c8",
10+
"commit": "a650d5133ce331e4303c2d01805936cf08aef05e",
1111
"ignore_in_git": True,
1212
},
1313
'buildtools/checkstyle/checkstyle.jar':{

0 commit comments

Comments
 (0)