Development Ideas

[friendly-bits]

There are lots of ideas discussed in the forum thread, so let's keep track of the ones which seem to be feasible here.
(this is open for dispute if anyone thinks that some idea is no good or should be changed)
I'd suggest to keep this issue as a list of ideas, and if you want to discuss an individual idea then open a separate issue for it or discuss in the forum.
@lynxthecat @Wizballs @rickparrish @dave14305

• Implement some sort of memory watchdog
• We could think (again) about implementing multithreaded download+preprocessing (not sure how useful this will actually be because of increased memory footprint)

Update Oct 18 2024: removed implemented ideas

[rickparrish]

Don't think I have enough input to create separate issues, so just adding my $0.02 here (which is mostly just saying "I'm all for these changes")

• I love the custom script idea. I'm not confident that I could escape things correctly to enter report_failure or report_success via a textarea on the luci app, but think I could figure it out via a custom script.
• And the session log will be very useful for the luci app. Yesterday I discovered RPC calls timeout after 30 seconds, and I haven't been able to figure out how to extend that. That means the Start button can't use RPC, so won't have access to any of the luci_* variables, so being able to get the session log from a temp file would be good.
• Would the "retrieve last session" command be for the luci app, or have other purpose too? If it's just for the luci app, and if the session log is stored to disk, then the luci app can read the file directly and I'd probably do that instead of use the command. If it's not stored to disk, then that's where the command could be convenient.

[lynxthecat]

How about local blocklist supports IPs?

[friendly-bits]

Is there a realistic use case? @lynxthecat

[lynxthecat]

Nothing specific comes to mind, but nevertheless I imagine there may well be use cases and it does seem like a cool extra feature to advertise. There was mention of this in the forum here.

[friendly-bits]

While dnsmasq does support this, IMO blocking IP addresses is more efficient when done in the firewall (i.e. via nftables set and nftables rules). If there really is a use case, we could either go the lazy route and just use dnsmasq, or add another module to adblock-lean which would create nft sets and firewall rules for those sets. The latter is obviously significantly more work, but this is how it's supposed to be done IMO. Generally, I feel that this goes beyond the core purpose of an adblocker, but I'm open for discussion.

[lynxthecat]

Yes I see your point. From symmetry perspective though we already support remote IP lists don’t we? So there is that. Maybe this is something to keep in mind in case a use case comes up in the future. Or an especially rainy day 🙂.