bugfix: Issues running from a project

Author: kspurgin

lib/kiba/extend/job_test/csv_job/equal.rb

@@ -48,6 +48,13 @@ def run
           end
 
           def required_keys = %i[select_field select_value test_field expected]
+
+          def key_conversions = {
+            select_field: :to_sym,
+            select_value: :to_s,
+            test_field: :to_sym,
+            expected: :to_s
+          }
         end
       end
     end

lib/kiba/extend/job_test/job_testable.rb

@@ -17,10 +17,12 @@ def result
           if run == :success
             config.merge({status: run})
           else
-            config.merge({status: :failure, got: run})
+            config.merge({status: :failure, got: err_msg(run)})
           end
         end
 
+        def job_data = @job_data ||= get_job_data
+
         private
 
         def initialization_logic(config, data = nil)
@@ -32,8 +34,6 @@ def initialization_logic(config, data = nil)
 
         def config = @config
 
-        def job_data = @job_data ||= get_job_data
-
         def validate_config(config)
           unless config.key?(:path)
             fail("#{self.class.name} requires a :path key in its config")
@@ -58,9 +58,31 @@ def validate_config_keys(config)
                 "#{missing.join(", ")}")
         end
 
+        def err_msg_prefix
+          parts = []
+          parts << loc if respond_to?(:loc)
+          parts << desc if respond_to?(:desc)
+          return if parts.empty?
+
+          parts << "Got"
+          parts.join("\n")
+        end
+
+        def err_msg(val) = [err_msg_prefix, val].compact.join(": ")
+
         def generate_instance_variable(key, val)
           iv = :"@#{key}"
-          instance_variable_set(iv, val)
+          conv = if respond_to?(:key_conversions)
+            if key_conversions.key?(key)
+              val.send(key_conversions[key])
+            else
+              val
+            end
+          else
+            val
+          end
+
+          instance_variable_set(iv, conv)
           self.class.define_method(key) { instance_variable_get(iv) }
         end
       end

lib/kiba/extend/job_test/job_tests_runner.rb

@@ -7,7 +7,7 @@ class JobTestsRunner
         # @param job [Symbol]
         # @param tests [Array<Hash>]
         def initialize(job, tests)
-          @job = job
+          @job = job.to_sym
           @tests = tests
           @status = :ok
         end
@@ -30,7 +30,7 @@ def call
 
         def set_path
           entry = Kiba::Extend.registry.resolve(job)
-          tests.each { |t| t[:path] = entry[:path] }
+          tests.each { |t| t[:path] = entry.path }
         rescue
           @status = :error
           msg = "#{job} job does not exist in registry"

lib/kiba/extend/job_test/suite_runner.rb

@@ -5,7 +5,7 @@ module Extend
     module JobTest
       class SuiteRunner
         # @param dir [String]
-        def initialize(dir = JobTest.job_test_dir_path)
+        def initialize(dir = JobTest.job_tests_dir_path)
           unless Dir.exist?(dir)
             fail("Cannot run job tests: #{dir} does not exist")
           end
@@ -14,17 +14,18 @@ def initialize(dir = JobTest.job_test_dir_path)
         end
 
         def call
-          tests_by_job.map { |job, tests| JobTestsRunner.new(job, tests).call }
-            .flatten
-            .each do |test|
-              next unless test[:status] == :failure
-
-              puts "\n#{test[:loc]}"
-              puts test[:desc]
-              puts "Got: #{test[:got]}"
-            end
+          results = run_tests
+          if results.key?(:failure)
+            results[:failure].each { |test| puts "Got: #{test[:got]}" }
+            puts "\n\nFailures: #{results[:failure].length}"
+          end
+          if results.key?(:success)
+            puts "Successes: #{results[:success].length}"
+          end
         end
 
+        def results = @results ||= run_tests
+
         private
 
         attr_reader :dir
@@ -33,6 +34,13 @@ def tests_by_job = Dir.children(dir)
           .map { |f| ConfigFilePrepper.new(File.join(dir, f)).call }
           .flatten
           .group_by { |config| config[:job] }
+
+        def run_tests
+          tests_by_job.map do |job, tests|
+            JobTestsRunner.new(job, tests).call
+          end.flatten
+            .group_by { |test| test[:status] }
+        end
       end
     end
   end

spec/kiba/extend/job_test/csv_job/equal_spec.rb

@@ -54,7 +54,7 @@
 
       it "returns actual data value" do
         expect(result[:status]).to eq(:failure)
-        expect(result[:got]).to eq("2")
+        expect(result[:got]).to end_with(" 2")
         expect(result[:desc]).to eq("When objectnumber is OBJ2, "\
                                     "numberofobjects == 127")
       end
@@ -73,7 +73,7 @@
 
       it "returns no rows message" do
         expect(result[:status]).to eq(:failure)
-        expect(result[:got]).to eq("no rows matching select criteria")
+        expect(result[:got]).to end_with("no rows matching select criteria")
       end
     end
   end

spec/kiba/extend/job_test/job_tests_runner_spec.rb

@@ -5,7 +5,10 @@
 RSpec.describe Kiba::Extend::JobTest::JobTestsRunner do
   subject(:runner) { described_class.new(job, tests) }
 
-  before(:all) { populate_registry }
+  before(:all) do
+    populate_registry
+    Kiba::Extend.registry.finalize
+  end
   after(:all) { Kiba::Extend.reset_config }
 
   describe "call" do

spec/kiba/extend/job_test/runner_spec.rb

@@ -79,7 +79,7 @@
 
       it "returns as expected" do
         expect(result[:status]).to eq(:failure)
-        expect(result[:got]).to eq("2")
+        expect(result[:got]).to end_with(" 2")
       end
     end
   end