Skip to content

Commit e078e11

Browse files
committed
feat: Include desc in dependency graphs
1 parent 2ec7003 commit e078e11

3 files changed

Lines changed: 24 additions & 7 deletions

File tree

lib/kiba/extend/registry/ancestorable.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,14 @@ module Registry
88
# Mixin module for getting Node and Edge properties from RegisteredSource
99
# and RegisteredLookup objects
1010
module Ancestorable
11+
include NodeLabelable
12+
1113
def node
1214
Diagrams::Elements::Node.new(id: node_id, label: node_label)
1315
end
1416

1517
def node_id = key.to_s
1618

17-
def node_label
18-
return node_id unless supplied
19-
20-
"#{node_id} (supplied)"
21-
end
22-
2319
def edge
2420
Diagrams::Elements::Edge.new(
2521
source_id: edge_source_id,
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# frozen_string_literal: true
2+
3+
module Kiba
4+
module Extend
5+
module Registry
6+
# Mixin module for generating Node label for dependency graph
7+
module NodeLabelable
8+
def node_label
9+
return "#{node_id} (supplied)" if supplied
10+
return node_id if desc.empty?
11+
12+
"#{node_id}\n#{desc}"
13+
end
14+
end
15+
end
16+
end
17+
end

lib/kiba/extend/registry/treeable.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ module Extend
88
module Registry
99
# Mixin module for generating dependency tree diagram for entry
1010
module Treeable
11+
include NodeLabelable
12+
1113
def parents
1214
files = creator.files
1315
[files[:source], files[:lookup]].compact
@@ -41,7 +43,9 @@ def traverse_up(elements)
4143
.compact
4244
end
4345

44-
def node = Diagrams::Elements::Node.new(id: key, label: key)
46+
def node_id = key
47+
48+
def node = Diagrams::Elements::Node.new(id: node_id, label: node_label)
4549

4650
def nodes = ancestors.uniq { |anc| anc.key }
4751
.map { |anc| anc.node } + [node]

0 commit comments

Comments
 (0)