Skip to content

Raise actually informative error if conditions passed to RowSelector result in non-array #123

Description

@kspurgin

Without this, we get an uninformative mess like:

/Users/kristina/code/mig/kiba-extend/lib/kiba/extend/utils/fieldset.rb:51:in `fetch': no implicit conversion of Symbol into Integer (TypeError)
	from /Users/kristina/code/mig/kiba-extend/lib/kiba/extend/utils/fieldset.rb:51:in `block in get_field_values'
	from /Users/kristina/code/mig/kiba-extend/lib/kiba/extend/utils/fieldset.rb:49:in `each'
	from /Users/kristina/code/mig/kiba-extend/lib/kiba/extend/utils/fieldset.rb:49:in `get_field_values'
	from /Users/kristina/code/mig/kiba-extend/lib/kiba/extend/utils/fieldset.rb:35:in `block in populate'
	from /Users/kristina/code/mig/kiba-extend/lib/kiba/extend/utils/fieldset.rb:35:in `each'
	from /Users/kristina/code/mig/kiba-extend/lib/kiba/extend/utils/fieldset.rb:35:in `populate'
	from /Users/kristina/code/mig/kiba-extend/lib/kiba/extend/transforms/merge/multi_row_lookup.rb:88:in `block in process'

Example of bad conditions lambda:

conditions: ->(_r, rows) do
  res = rows.select{ |row| row[:contype] == 'Organization' }
  res.empty? ? res :  res.first
end

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions