Skip to content

Commit 4c0cbe3

Browse files
committed
Merge branch 'dev'
2 parents a3493a6 + 462dc5d commit 4c0cbe3

8 files changed

Lines changed: 55 additions & 41 deletions

File tree

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,15 @@ Project versioning adheres to [Semantic Versioning](http://semver.org/).
66
Commit convention is based on [Conventional Commits](http://conventionalcommits.org).
77
Change log format is based on [Keep a Changelog](http://keepachangelog.com/).
88

9+
## [1.4.1](https://github.com/lyswhut/lx-music-desktop/compare/v1.4.0...v1.4.1) - 2020-11-25
10+
11+
12+
### 修复
13+
14+
- 修复有歌词翻译与无歌词的音乐间切换会导致歌词翻译残留显示的问题
15+
- 修复歌曲URL过期时,等待刷新URL的自动切换歌曲时间间隔太短的问题
16+
- 修复某些电脑上的某些歌曲没有声音的问题(升级Electron9.3.4导致的,现降级到9.3.3)
17+
918
## [1.4.0](https://github.com/lyswhut/lx-music-desktop/compare/v1.3.0...v1.4.0) - 2020-11-21
1019

1120
### 新增

FAQ.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@
3939

4040
播放在线列表内的歌曲需要将它们都添加到我的列表才能播放,你可以全选列表内的歌曲然后添加到现有列表或者新创建的列表,然后去播放该列表内的歌曲。
4141

42+
## 无法打开外部歌单
43+
44+
不支持垮源打开歌单,请**确认**你需要打开的歌单平台是否与软件标签所写的**歌单源**对应(不一样的话请通过右上角切换歌单源);<br>
45+
对于分享出来的歌单,若打开失败,可尝试先在浏览器中打开后,再从浏览器地址栏复制URL地址到软件打开;<br>
46+
或者如果你知道歌单 id 也可以直接输入歌单 id 打开。<br>
47+
4248
## Windows 7 下界面异常(界面显示不完整)
4349

4450
由于软件默认使用了透明窗口,根据Electron官方文档的[说明](https://electronjs.org/docs/api/frameless-window#%E5%B1%80%E9%99%90%E6%80%A7)
@@ -70,12 +76,6 @@
7076
- 清理安装路径下的残留文件
7177
- 清理注册表(建议用清理工具清理)
7278

73-
## 无法打开外部歌单
74-
75-
不支持垮源打开歌单,请**确认**你需要打开的歌单平台是否与软件标签所写的**歌单源**对应(不一样的话请通过右上角切换歌单源);<br>
76-
对于分享出来的歌单,若打开失败,可尝试先在浏览器中打开后,再从浏览器地址栏复制URL地址到软件打开;<br>
77-
或者如果你知道歌单 id 也可以直接输入歌单 id 打开。<br>
78-
7979
## 软件无法联网
8080

8181
软件的排行榜、歌单、搜索列表****无法加载:

package-lock.json

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "lx-music-desktop",
3-
"version": "1.4.0",
3+
"version": "1.4.1",
44
"description": "一个免费的音乐下载助手",
55
"main": "./dist/electron/main.js",
66
"productName": "lx-music-desktop",
@@ -176,7 +176,7 @@
176176
"cross-env": "^7.0.2",
177177
"css-loader": "^4.3.0",
178178
"del": "^6.0.0",
179-
"electron": "^9.3.4",
179+
"electron": "^9.3.3",
180180
"electron-builder": "^22.9.1",
181181
"electron-debug": "^3.1.0",
182182
"electron-devtools-installer": "^3.1.1",

publish/changeLog.md

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
1-
### 新增
2-
3-
- 托盘菜单新增显示、隐藏主界面选项,为Linux、MAC版添加托盘菜单
4-
- 新增播放进度信息保存
5-
6-
### 优化
7-
8-
- 移除kg源的歌词文件开头的空白字符串
91

102
### 修复
113

12-
- 修复专辑图片无法嵌入的问题
13-
- 修复播放状态栏切换“上一首”歌曲按钮提示错误的问题
14-
- 修复移动单首歌曲时,如果目标列表存在该歌曲,会导致将源列表与目标列表里的目标歌曲移除
15-
- 修复kg源歌曲信息带有单引号等特殊字符被转义的问题
4+
- 修复有歌词翻译与无歌词的音乐间切换会导致歌词翻译残留显示的问题
5+
- 修复歌曲URL过期时,等待刷新URL的自动切换歌曲时间间隔太短的问题
6+
- 修复某些电脑上的某些歌曲没有声音的问题(升级Electron9.3.4导致的,现降级到9.3.3)

publish/version.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

src/renderer-lyric/components/core/Lyric.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ export default {
279279
rendererSend(NAMES.winLyric.close)
280280
},
281281
setLyric() {
282-
window.lrc.setLyric((this.isShowLyricTransition && this.lyrics.tlyric ? this.lyrics.tlyric + '\n' : '') + this.lyrics.lyric)
282+
window.lrc.setLyric((this.isShowLyricTransition && this.lyrics.tlyric ? (this.lyrics.tlyric + '\n') : '') + (this.lyrics.lyric || ''))
283283
},
284284
},
285285
}

src/renderer/components/core/Player.vue

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,8 @@ export default {
373373
this.addDelayNextTimeout()
374374
})
375375
audio.addEventListener('loadeddata', () => {
376-
// console.log('loadeddata')
376+
console.log('loadeddata')
377+
this.clearLoadingTimeout()
377378
this.status = this.statusText = this.$t('core.player.loading')
378379
this.maxPlayTime = audio.duration
379380
if (window.restorePlayInfo) {
@@ -388,8 +389,8 @@ export default {
388389
if (!this.targetSong.interval && this.listId != 'download') this.updateMusicInfo({ id: this.listId, index: this.playIndex, data: { interval: formatPlayTime2(this.maxPlayTime) } })
389390
})
390391
audio.addEventListener('loadstart', () => {
391-
// console.log('loadstart')
392-
this.startBuffering()
392+
console.log('loadstart')
393+
this.startLoadingTimeout()
393394
this.status = this.statusText = this.$t('core.player.loading')
394395
})
395396
audio.addEventListener('canplay', () => {
@@ -399,9 +400,8 @@ export default {
399400
this.mediaBuffer.playTime = 0
400401
audio.currentTime = playTime
401402
}
402-
if (this.mediaBuffer.timeout) {
403-
this.clearBufferTimeout()
404-
}
403+
this.clearBufferTimeout()
404+
405405
// if (this.musicInfo.lrc) window.lrc.play(audio.currentTime * 1000)
406406
this.status = this.statusText = ''
407407
})
@@ -412,6 +412,7 @@ export default {
412412
// })
413413
audio.addEventListener('emptied', () => {
414414
this.mediaBuffer.playTime = 0
415+
this.clearLoadingTimeout()
415416
this.clearBufferTimeout()
416417
417418
// console.log('媒介资源元素突然为空,网络错误 or 切换歌曲?')
@@ -713,6 +714,7 @@ export default {
713714
this.status = this.musicInfo.name = this.musicInfo.singer = ''
714715
this.musicInfo.songmid = null
715716
this.musicInfo.lrc = null
717+
this.musicInfo.tlrc = null
716718
this.musicInfo.url = null
717719
this.nowPlayTime = 0
718720
this.maxPlayTime = 0
@@ -795,8 +797,20 @@ export default {
795797
// console.log(e)
796798
this.isActiveTransition = false
797799
},
800+
startLoadingTimeout() {
801+
// console.log('start load timeout')
802+
this.loadingTimeout = setTimeout(() => {
803+
this.handleNext()
804+
}, 10000)
805+
},
806+
clearLoadingTimeout() {
807+
if (!this.loadingTimeout) return
808+
// console.log('clear load timeout')
809+
clearTimeout(this.loadingTimeout)
810+
this.loadingTimeout = null
811+
},
798812
startBuffering() {
799-
console.log('start t')
813+
console.error('start t')
800814
if (this.mediaBuffer.timeout) return
801815
this.mediaBuffer.timeout = setTimeout(() => {
802816
this.mediaBuffer.timeout = null
@@ -891,7 +905,7 @@ export default {
891905
})
892906
},
893907
setLyric() {
894-
window.lrc.setLyric((this.setting.player.isShowLyricTransition && this.musicInfo.tlrc ? this.musicInfo.tlrc + '\n' : '') + this.musicInfo.lrc)
908+
window.lrc.setLyric((this.setting.player.isShowLyricTransition && this.musicInfo.tlrc ? (this.musicInfo.tlrc + '\n') : '') + (this.musicInfo.lrc || ''))
895909
if (this.isPlay && (this.musicInfo.url || this.listId == 'download')) {
896910
window.lrc.play(audio.currentTime * 1000)
897911
this.handleUpdateWinLyricInfo('play', audio.currentTime * 1000)

0 commit comments

Comments
 (0)