Merge pull request #47 from mensch272/wb@mensch

Removed url lazy loading from db in favour of sql statement

Author: m-haisham

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased] - yyyy-mm-dd
 
+## Changed
+
+- Removed url lazy loading from db in favour of sql statement
+
 ## Fixed
 
 - Fixed where provided webnovel urls not added to db #44

novelsave/services/novel/novel_service.py

@@ -36,10 +36,14 @@ def get_novel_by_url(self, url: str) -> Optional[Novel]:
         return self.session.execute(sql).scalars().first()
 
     def get_primary_url(self, novel: Novel) -> str:
-        return novel.urls[0].url
+        return self.get_urls(novel)[0].url
 
     def get_urls(self, novel) -> List[NovelUrl]:
-        return novel.urls
+        return (
+            self.session.execute(select(NovelUrl).filter(NovelUrl.novel_id == novel.id))
+            .scalars()
+            .all()
+        )
 
     def get_chapters(self, novel: Novel) -> List[Chapter]:
         return (