Skip to content

Commit 0216d60

Browse files
Add period label to AutoloadDuration metric (#19)
1 parent b2ea985 commit 0216d60

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

handler/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ func (c *Client) Load(w http.ResponseWriter, r *http.Request) {
6363
t := time.Now()
6464
err := c.processDatatype(ctx, dt, opts)
6565
if err != nil {
66-
metrics.AutoloadDuration.WithLabelValues(dt.Experiment, dt.Name, "error").Observe(time.Since(t).Seconds())
66+
metrics.AutoloadDuration.WithLabelValues(dt.Experiment, dt.Name, opts.period, "error").Observe(time.Since(t).Seconds())
6767
errs = append(errs, fmt.Sprintf("failed to autoload %s.%s: %s", dt.Experiment, dt.Name, err.Error()))
6868
continue
6969
}
70-
metrics.AutoloadDuration.WithLabelValues(dt.Experiment, dt.Name, "OK").Observe(time.Since(t).Seconds())
70+
metrics.AutoloadDuration.WithLabelValues(dt.Experiment, dt.Name, opts.period, "OK").Observe(time.Since(t).Seconds())
7171
}
7272

7373
if len(errs) != 0 {

metrics/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ var (
1919
10000, 21500, 46400,
2020
},
2121
},
22-
[]string{"experiment", "datatype", "status"},
22+
[]string{"experiment", "datatype", "period", "status"},
2323
)
2424

2525
// BigQueryOperationsTotal counts the number of create, update, and load operations

metrics/metrics_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package metrics
33
import "testing"
44

55
func TestLintMetrics(t *testing.T) {
6-
AutoloadDuration.WithLabelValues("experiment", "datatype", "status")
6+
AutoloadDuration.WithLabelValues("experiment", "datatype", "period", "status")
77
BigQueryOperationsTotal.WithLabelValues("experiment", "datatype", "operation", "status")
88
LoadedDates.WithLabelValues("experiment", "datatype", "period", "status")
99
}

0 commit comments

Comments
 (0)