Merge pull request #507 from m-lab/fix-enqueue-unit-tests

We changed function names without running the unit tests.

Author: pboothe

.travis.yml

@@ -18,6 +18,13 @@
 language: go
 
 before_install:
+# Install javascript libraries
+- pushd $TRAVIS_BUILD_DIR/functions
+- npm install --verbose
+- pushd embargo
+- npm install --verbose
+- popd; popd
+
 # Coverage tools
 - go get github.com/mattn/goveralls
 - go get github.com/wadey/gocovmerge
@@ -43,7 +50,14 @@ cache:
     - "$HOME/google-cloud-sdk/"
 
 script:
-# To start, run all the non-integration tests.
+# Run all javascript tests.
+- pushd $TRAVIS_BUILD_DIR/functions
+- npm test
+- pushd embargo
+- npm test
+- popd; popd
+
+# To start the Go tests, run all the non-integration tests.
 # Currently skipping storage tests, because they depend on GCS, and there is
 # no emulator.
 # TODO - separate storage tests into integration and lightweight.

functions/embargo/package.json

@@ -8,5 +8,8 @@
   },
   "dependencies": {
     "googleapis": "~19.0.0"
+  },
+  "scripts": {
+    "test": "echo THIS CODE IS UNTESTED"
   }
 }

functions/enqueue_test.js

@@ -8,7 +8,7 @@ const sample_data = { kind: 'storage#object', resourceState: 'exists', id: 'm-la
 describe("ProcessNotification", function () {
   it("calls the callback", function () {
     var callback = sinon.spy()
-    enqueue.fileNotification({"data": sample_data}, callback);
+    enqueue.createStagingTaskOnFileNotification({"data": sample_data}, callback);
     assert(callback.called);
   });
 });

functions/package.json

@@ -15,6 +15,6 @@
     "sinon": "~2.1.0"
   },
   "scripts": {
-    "test": "nodejs node_modules/.bin/mocha --reporter spec *_test.js"
+    "test": "node node_modules/.bin/mocha --reporter spec *_test.js"
   }
 }