Fix goroutine "leak" introduced last week in tcpinfo (#844)

* make sync to avoid goroutine growth

* remove incorrect TODO

* Fix deadlock

* clean up curly brackets

Author: gfr10598

bq/insert.go

@@ -363,7 +363,6 @@ func (in *BQInserter) Flush() error {
 // Commit implements row.Sink.
 // NOTE: the label is ignored, and the TableBase is used instead.
 func (in *BQInserter) Commit(rows []interface{}, label string) error {
-	// TODO - this causes large memory and large number of goroutines.
 	in.acquire()
 	defer in.release()
 	return in.flushSlice(rows)

row/row.go

@@ -271,6 +271,7 @@ func (pb *Base) commit(rows []interface{}) error {
 	// TODO - care about error?
 	_ = pb.ann.Annotate(rows, pb.label)
 	// TODO do we need these to be done in order.
+	// This is synchronous, blocking, and thread safe.
 	err := pb.sink.Commit(rows, pb.label)
 
 	pb.statsLock.Lock()
@@ -300,16 +301,18 @@ func (pb *Base) Flush() error {
 func (pb *Base) Put(row Annotatable) {
 	rows := pb.buf.Append(row)
 	pb.statsLock.Lock()
-	defer pb.statsLock.Unlock()
 	pb.stats.Total++
 	pb.stats.Pending++
+	pb.statsLock.Unlock()
+
 	if rows != nil {
-		go func(rows []interface{}) {
-			// This allows pipelined parsing annotating, and writing.
-			err := pb.commit(rows)
-			if err != nil {
-				log.Println(err)
-			}
-		}(rows)
+		// This allows pipelined parsing annotating, and writing.
+		// Disabling for now, as it leads to large memory/goroutine footprint.
+		//	go func(rows []interface{}) {
+		err := pb.commit(rows)
+		if err != nil {
+			log.Println(err)
+		}
+		//	}(rows)
 	}
 }