Fix the missing last few tests for a tarball (#830)

* Update pt.go

* add unittest

* fix diff

* move code

Author: yachang

parser/pt.go

@@ -479,12 +479,15 @@ func (pt *PTParser) ProcessLastTests() error {
 	for _, oneTest := range pt.previousTests {
 		pt.InsertOneTest(oneTest)
 	}
+
 	pt.previousTests = []cachedPTData{}
 	return nil
 }
 
 func (pt *PTParser) Flush() error {
 	pt.ProcessLastTests()
+	pt.Annotate(pt.TableName())
+	pt.Put(pt.TakeRows())
 	return pt.Inserter.Flush()
 }
 

parser/pt_test.go

@@ -271,6 +271,34 @@ func TestPTInserter(t *testing.T) {
 	}
 }
 
+func TestPTInserterLastTest(t *testing.T) {
+	ins := newInMemoryInserter()
+	pt := parser.NewPTParser(ins)
+	rawData, err := ioutil.ReadFile("testdata/PT/20130524T00:04:44Z_ALL5729.paris")
+	if err != nil {
+		t.Fatalf("cannot read testdata.")
+	}
+	meta := map[string]bigquery.Value{"filename": "gs://fake-bucket/fake-archive.tgz"}
+	err = pt.ParseAndInsert(meta, "testdata/PT/20130524T00:04:44Z_ALL5729.paris", rawData)
+	if err != nil {
+		t.Fatalf(err.Error())
+	}
+
+	if pt.NumRowsForTest() != 0 {
+		fmt.Println(pt.NumRowsForTest())
+		t.Fatalf("The data is not inserted, in buffer now.")
+	}
+	pt.Flush()
+
+	if len(ins.data) != 1 {
+		fmt.Println(len(ins.data))
+		t.Fatalf("Number of rows in inserter is wrong.")
+	}
+	if ins.data[0].(*schema.PTTest).Parseinfo.TaskFileName != "gs://fake-bucket/fake-archive.tgz" {
+		t.Fatalf("Task filename is wrong.")
+	}
+}
+
 func TestPTPollutionCheck(t *testing.T) {
 	ins := &inMemoryInserter{}
 	pt := parser.NewPTParser(ins)
@@ -345,7 +373,7 @@ func TestPTPollutionCheck(t *testing.T) {
 	// Insert the 4th test in the buffer to BigQuery.
 	pt.ProcessLastTests()
 	if pt.NumRowsForTest() != 4 {
-		t.Fatalf("Number of tests in buffer not correct, expect 4, actually %d.", ins.RowsInBuffer())
+		t.Fatalf("Number of tests in buffer not correct, expect 0, actually %d.", ins.RowsInBuffer())
 	}
 }
 

parser/testdata/PT/20130524T00:04:44Z_ALL5729.paris

@@ -0,0 +1,17 @@
+traceroute [(91.239.96.102:33456) -> (2.80.132.33:33457)], protocol icmp, algo exhaustive, duration 19 s
+ 1  P(6, 6) 91.239.96.65 (91.239.96.65)  0.246/0.284/0.314/0.020 ms 
+ 2  P(6, 6) mx-lj1-ge-0-0-3-v110.amis.net (90.157.211.89)  0.984/4.166/19.768/6.978 ms 
+ 3  P(6, 6) mx-vi1-te-0-0-0.amis.net (212.18.44.142)  8.602/13.981/40.600/11.904 ms 
+ 4  P(6, 6) te0-0-2.frk1-cr1.cprm.net (80.81.192.38)  22.939/25.367/26.480/1.193 ms 
+ 5  P(6, 6) ams1-cr1-te0-0-2.cprm.net (195.8.1.33)  29.842/33.365/43.589/4.696 ms 
+ 6  P(6, 6) lon1-cr1-te7-0-5.cprm.net (195.8.0.249)  74.040/77.631/81.690/2.422 ms 
+ 7  P(6, 6) lis2-cr1-be3.cprm.net (195.8.0.217)  76.171/78.649/81.650/1.768 ms !T2 
+ 8  P(6, 6) bt-cr1-hu5-0-0.cprm.net (195.8.1.58)  74.433/88.352/124.008/17.892 ms !T3 
+ 9  P(6, 6) dvs-cr1-hu2.cprm.net (195.8.1.13)  74.754/76.854/78.521/1.361 ms 
+10  P(6, 6) telepac4-huge.cprm.net (195.8.10.206)  76.260/78.578/81.592/1.717 ms 
+11  P(6, 6) 194.65.12.153 (194.65.12.153)  74.305/83.235/123.161/17.875 ms 
+12  P(0, 6)
+13  P(0, 6)
+14  P(0, 6)
+
+