Skip to content

Commit b8c7c40

Browse files
authored
Merge pull request #155 from m-lab/prod-config
reduce spammy logs
2 parents 36c6668 + 603debf commit b8c7c40

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

parser/ndt.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -269,11 +269,8 @@ func (n *NDTParser) reportAnomalies() {
269269
}
270270
metrics.WarningCount.WithLabelValues(
271271
n.TableName(), "group", tag).Inc()
272-
// If no meta file, or ONLY meta file, then log. This is about 10%
273-
// of all tests, so it is pretty spammy.
274-
if code <= 4 {
275-
log.Printf("%s: from %s at %s\n", tag, n.taskFileName, n.timestamp)
276-
}
272+
// Logging missing meta file is too spammy. Should restore this when
273+
// NDT is fixed.
277274
}
278275
}
279276

@@ -339,7 +336,6 @@ func (n *NDTParser) getAndInsertValues(test *fileInfoAndData, testType string) {
339336
metrics.WorkerState.WithLabelValues("parse").Inc()
340337
defer metrics.WorkerState.WithLabelValues("parse").Dec()
341338

342-
// TODO - is this too spammy?
343339
if !strings.HasSuffix(test.fn, ".gz") {
344340
metrics.WarningCount.WithLabelValues(
345341
n.TableName(), testType, "uncompressed file").Inc()

0 commit comments

Comments
 (0)