Skip to content

Commit 8b6a257

Browse files
Make NewLoader accept a pointer (#167)
* Make NewLoader accept a pointer * Fix test
1 parent e27f60e commit 8b6a257

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

cloudtest/bqfake/bqfake.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,12 @@ func (q Query) Read(context.Context) (bqiface.RowIterator, error) {
200200
// Loader implements parts of bqiface.Loader to allow for testing.
201201
type Loader struct {
202202
bqiface.Loader
203-
job Job
203+
job *Job
204204
err error
205205
}
206206

207207
// NewLoader returns a new instance of Loader.
208-
func NewLoader(job Job, err error) *Loader {
208+
func NewLoader(job *Job, err error) *Loader {
209209
return &Loader{
210210
job: job,
211211
err: err,

cloudtest/bqfake/bqfake_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ func TestTableUpdate(t *testing.T) {
280280
}
281281

282282
func TestTableLoaderFrom(t *testing.T) {
283-
ldr := bqfake.NewLoader(bqfake.Job{}, nil)
283+
ldr := bqfake.NewLoader(&bqfake.Job{}, nil)
284284
tbl := bqfake.NewTable(bqfake.TableOpts{
285285
Loader: ldr,
286286
})
@@ -386,7 +386,7 @@ func TestNewQueryReadClient(t *testing.T) {
386386
}
387387

388388
func TestLoaderRun(t *testing.T) {
389-
job := bqfake.Job{}
389+
job := &bqfake.Job{}
390390
err := errors.New("loader error")
391391
ldr := bqfake.NewLoader(job, err)
392392
got, gotErr := ldr.Run(context.Background())

0 commit comments

Comments
 (0)