Skip to content

Commit a896eda

Browse files
authored
Increases max instances to 20 for Locate Service (#57)
* Increases max instances to 20 for Locate Service There is no need to limit the number of instances of the Locate Service that AppEngine can launch to scale up the app. The default max is 8, and this change sets the max to what I hope will be a very generous ceiling of 20. I removed the min number of instances configurations, since its value (2) was equal to the default for automatic scaling. * Changes location of go-jose.v2 package Builds were failing while fetching the package. It used to be located at: "gopkg.in/square/go-jose.v2/jwt" ... but is apparently now located at: "gopkg.in/go-jose/go-jose.v2/jwt" * Updates Travis build env to use Go 1.16 * Causes Travis to use Ubuntu Focal for builds * Reinstalls ca-certificates Ubuntu package * Moves reinstall of ca-certs to before_install * Uses sudo to run apt reinstall ca-certificates * Runs apt-update before apt-reinstall * Revert "Changes location of go-jose.v2 package" This reverts commit 8a99ffa.
1 parent d74454d commit a896eda

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.travis.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1+
dist: focal
2+
13
language: go
24

35
go:
4-
- 1.14.2
6+
- 1.16
7+
8+
before_install:
9+
- sudo apt update
10+
- sudo apt reinstall --yes ca-certificates
511

612
install:
713
- go get -v -t ./...

cloudbuild/app-platform.yaml.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ resources:
77
memory_gb: 4
88

99
automatic_scaling:
10-
min_num_instances: 2
1110
max_num_instances: 4
1211
# Anecdotally, it seems to take roughly 5m for an instance to initialize
1312
# fully.

cloudbuild/app.yaml.template

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ resources:
1212
memory_gb: 8
1313

1414
automatic_scaling:
15-
min_num_instances: 2
16-
max_num_instances: 4
15+
max_num_instances: 20
1716
# Anecdotally, it seems to take roughly 5m for an instance to initialize
1817
# fully.
1918
cool_down_period_sec: 300

0 commit comments

Comments
 (0)