Commit c583f65
authored
fix: use includes() check for project placeholder to survive sed substitution (#164)
The CI pipeline runs `sed -i 's/MLAB_PROJECT_PLACEHOLDER/mlab-oti/g'`
to set the production project. The previous strict equality check
`placeholder === 'MLAB_PROJECT_PLACEHOLDER'` became
`'mlab-oti' === 'mlab-oti'` after substitution, which is always true,
causing production to use the mlab-staging fallback.
Using `placeholder.includes('PLACEHOLDER')` instead ensures the check
correctly detects an unsubstituted placeholder while evaluating to false
after sed replaces it with 'mlab-oti'.
This bug has been silently routing all ndt7 tests from the website to
staging infrastructure since the 2026-02-03 release, causing a 99% drop
in ndt7 test data in production BigQuery.1 parent 755cdfa commit c583f65
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| |||
0 commit comments