Skip to content

Commit 10e35e6

Browse files
authored
[vpj] fix string format when REWIND_FROM_SOP is enforced (linkedin#2088)
use %s instead of {} within String.format() to print the missing contents
1 parent cabc03e commit 10e35e6

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1915,7 +1915,7 @@ protected void validateRemoteHybridSettings(PushJobSetting setting) {
19151915
if (!setting.validateRemoteReplayPolicy.equals(hybridStoreConfig.getBufferReplayPolicy())) {
19161916
throw new VeniceException(
19171917
String.format(
1918-
"Remote rewind policy is {} but push settings require a policy of {}. "
1918+
"Remote rewind policy is %s but push settings require a policy of %s. "
19191919
+ "Please adjust hybrid settings or push job configuration!",
19201920
hybridStoreConfig.getBufferReplayPolicy(),
19211921
setting.validateRemoteReplayPolicy));

clients/venice-push-job/src/main/java/com/linkedin/venice/vpj/VenicePushJobConstants.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,13 @@ private VenicePushJobConstants() {
235235
*/
236236
public static final String REWIND_EPOCH_TIME_IN_SECONDS_OVERRIDE = "rewind.epoch.time.in.seconds.override";
237237

238+
/**
239+
* Relates to the {@link #REWIND_EPOCH_TIME_IN_SECONDS_OVERRIDE}. An overridable amount of buffer to be applied to the epoch
240+
* (as the rewind isn't perfectly instantaneous). Defaults to 1 minute.
241+
*/
242+
public static final String REWIND_EPOCH_TIME_BUFFER_IN_SECONDS_OVERRIDE =
243+
"rewind.epoch.time.buffer.in.seconds.override";
244+
238245
/**
239246
* This config is a boolean which suppresses submitting the end of push message after data has been sent and does
240247
* not poll for the status of the job to complete. Using this flag means that a user must manually mark the job success
@@ -258,13 +265,6 @@ private VenicePushJobConstants() {
258265
*/
259266
public static final String PARENT_CONTROLLER_REGION_NAME = "parent.controller.region.name";
260267

261-
/**
262-
* Relates to the above argument. An overridable amount of buffer to be applied to the epoch (as the rewind isn't
263-
* perfectly instantaneous). Defaults to 1 minute.
264-
*/
265-
public static final String REWIND_EPOCH_TIME_BUFFER_IN_SECONDS_OVERRIDE =
266-
"rewind.epoch.time.buffer.in.seconds.override";
267-
268268
/**
269269
* In single-region mode, this must be a comma-separated list of child controller URLs or {@literal d2://<d2ServiceNameForChildController>}
270270
* In multi-region mode, it must be a comma-separated list of parent controller URLs or {@literal d2://<d2ServiceNameForParentController>}

0 commit comments

Comments
 (0)