Commit 9f0a2f7
authored
[server] Fix spammy logging when reporting backup version's replica ingestion timeout (linkedin#2359)
This PR addresses a spammy log issue when replica bootstrap timeout happens.
Previously, when a push timed out, SIT would throw an exception unconditionally
and stop consumption for all replicas.
In a previous PR (linkedin#2284), when a backup or current version replica bootstrap
times out, SIT no longer throws an exception but instead reports ERROR to PCS.
For current version replicas, a reset feature may kick in to configure a
Helix reset. For backup version replicas, such a feature is not triggered,
and as a result, each check loop repeatedly reports the same log, which is
not expected.
We may consider extending the error reset feature to backup versions once it
is stabilized, but this fix is still needed regardless. This PR resolves the
issue by checking whether PCS has already reported ERROR. For replicas that
have timed out and already reported ERROR, it will no longer log repeatedly.1 parent 034453e commit 9f0a2f7
1 file changed
Lines changed: 4 additions & 4 deletions
File tree
- clients/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
622 | 622 | | |
623 | 623 | | |
624 | 624 | | |
625 | | - | |
626 | | - | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
627 | 628 | | |
628 | 629 | | |
629 | 630 | | |
| |||
785 | 786 | | |
786 | 787 | | |
787 | 788 | | |
788 | | - | |
| 789 | + | |
789 | 790 | | |
790 | 791 | | |
791 | 792 | | |
792 | 793 | | |
793 | | - | |
794 | 794 | | |
795 | 795 | | |
796 | 796 | | |
| |||
0 commit comments