[venice-common] Fix missing SchemaAdapter.adaptToSchema() in (linkedin#2640)

Fix schema adaptation in setElementsToRemoveFromListField                    

setElementsToRemoveFromListField in UpdateBuilderImpl does not call           
SchemaAdapter.adaptToSchema() on elementsToRemove, unlike the symmetric      
setElementsToAddToListField method which does. This causes Avro              
serialization failures when input records have extra fields (e.g., from      
an evolved schema) that do not match the Venice WriteOp schema.              

The root cause exception is:                                                 
java.lang.ClassCastException: class java.lang.Long cannot be cast to class   
java.util.List during serialization, because unadapted records with          
mismatched schemas are placed into the setDiff field.                        

Add the missing SchemaAdapter.adaptToSchema() call in                        
setElementsToRemoveFromListField, making it consistent with                  
setElementsToAddToListField, setEntriesToAddToMapField, and                  
setNewFieldValue.

Author: sixpluszero

internal/venice-common/src/main/java/com/linkedin/venice/writer/update/UpdateBuilderImpl.java

@@ -72,7 +72,9 @@ public UpdateBuilder setElementsToRemoveFromListField(String listFieldName, List
     validateFieldType(Validate.notNull(listFieldName), Schema.Type.ARRAY);
     validateFieldNotSet(listFieldName);
     if (!elementsToRemove.isEmpty()) {
-      getOrCreateListMergeRecord(listFieldName).put(WriteComputeConstants.SET_DIFF, elementsToRemove);
+      getOrCreateListMergeRecord(listFieldName).put(
+          WriteComputeConstants.SET_DIFF,
+          SchemaAdapter.adaptToSchema(getCorrespondingValueFieldSchema(listFieldName), elementsToRemove));
       collectionMergeFieldNameSet.add(listFieldName);
     }
     return this;

internal/venice-common/src/test/java/com/linkedin/venice/writer/update/UpdateBuilderImplTest.java

@@ -116,6 +116,27 @@ public void testUpdateEvolvedSubfieldRemoveFieldsNotInUpdateSchema() {
     Assert.assertEquals(recordMapMergeRecord.get("mapDiff"), Collections.emptyList());
   }
 
+  @Test
+  public void testUpdateEvolvedSubfieldRemoveFromListFieldAdaptsSchema() {
+    UpdateBuilder builder = new UpdateBuilderImpl(UPDATE_SCHEMA);
+
+    List<GenericRecord> writeRecordArrayToRemove = new ArrayList<>();
+    writeRecordArrayToRemove.add(createEvolvedRecordForListField(1, "testName"));
+
+    List<GenericRecord> expectedRecordArrayToRemove = new ArrayList<>();
+    expectedRecordArrayToRemove.add(createRecordForListField(1));
+
+    builder.setNewFieldValue("name", "Lebron James");
+    builder.setElementsToRemoveFromListField("recordArray", writeRecordArrayToRemove);
+
+    GenericRecord updateRecord = builder.build();
+
+    Assert.assertTrue(updateRecord.get("recordArray") instanceof GenericRecord);
+    GenericRecord listMergeRecord = (GenericRecord) updateRecord.get("recordArray");
+    Assert.assertEquals(listMergeRecord.get("setUnion"), Collections.emptyList());
+    Assert.assertEquals(listMergeRecord.get("setDiff"), expectedRecordArrayToRemove);
+  }
+
   @Test
   public void testUpdateEvolvedSubfieldFillDefaultsForUnspecifiedFields() {
     UpdateBuilder builder = new UpdateBuilderImpl(EVOLVED_UPDATE_SCHEMA);