Skip to content

Commit ff0158e

Browse files
committed
[vpj] fix string format when REWIND_FROM_SOP is enforced
1 parent 8fc4ecc commit ff0158e

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1905,7 +1905,7 @@ protected void validateRemoteHybridSettings(PushJobSetting setting) {
19051905
if (!setting.validateRemoteReplayPolicy.equals(hybridStoreConfig.getBufferReplayPolicy())) {
19061906
throw new VeniceException(
19071907
String.format(
1908-
"Remote rewind policy is {} but push settings require a policy of {}. "
1908+
"Remote rewind policy is %s but push settings require a policy of %s. "
19091909
+ "Please adjust hybrid settings or push job configuration!",
19101910
hybridStoreConfig.getBufferReplayPolicy(),
19111911
setting.validateRemoteReplayPolicy));

clients/venice-push-job/src/main/java/com/linkedin/venice/vpj/VenicePushJobConstants.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,13 @@ private VenicePushJobConstants() {
151151
*/
152152
public static final String REWIND_EPOCH_TIME_IN_SECONDS_OVERRIDE = "rewind.epoch.time.in.seconds.override";
153153

154+
/**
155+
* Relates to the {@link #REWIND_EPOCH_TIME_IN_SECONDS_OVERRIDE}. An overridable amount of buffer to be applied to the epoch
156+
* (as the rewind isn't perfectly instantaneous). Defaults to 1 minute.
157+
*/
158+
public static final String REWIND_EPOCH_TIME_BUFFER_IN_SECONDS_OVERRIDE =
159+
"rewind.epoch.time.buffer.in.seconds.override";
160+
154161
/**
155162
* This config is a boolean which suppresses submitting the end of push message after data has been sent and does
156163
* not poll for the status of the job to complete. Using this flag means that a user must manually mark the job success
@@ -174,13 +181,6 @@ private VenicePushJobConstants() {
174181
*/
175182
public static final String PARENT_CONTROLLER_REGION_NAME = "parent.controller.region.name";
176183

177-
/**
178-
* Relates to the above argument. An overridable amount of buffer to be applied to the epoch (as the rewind isn't
179-
* perfectly instantaneous). Defaults to 1 minute.
180-
*/
181-
public static final String REWIND_EPOCH_TIME_BUFFER_IN_SECONDS_OVERRIDE =
182-
"rewind.epoch.time.buffer.in.seconds.override";
183-
184184
/**
185185
* In single-region mode, this must be a comma-separated list of child controller URLs or {@literal d2://<d2ServiceNameForChildController>}
186186
* In multi-region mode, it must be a comma-separated list of parent controller URLs or {@literal d2://<d2ServiceNameForParentController>}

0 commit comments

Comments
 (0)