feat: remove fee estimation endpoint

Author: m0wer

CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Removed
+- Fee estimation endpoint (`/v1/fees/estimate`) - Neutrino light clients don't have access to mempool data anyway, so this endpoint was misleading
+
 ## [0.5.0] - 2025-12-30
 
 ### Added
@@ -102,7 +105,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 - Initial Neutrino API Server implementation
-- REST API with 9 comprehensive endpoints:
+- REST API with 8 comprehensive endpoints:
   - Status and sync monitoring (`/v1/status`)
   - Block header queries (`/v1/block/{height}/header`)
   - Filter header queries (`/v1/block/{height}/filter_header`)
@@ -111,7 +114,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Address watching (`/v1/watch/address`)
   - Outpoint watching (`/v1/watch/outpoint`)
   - Blockchain rescanning (`/v1/rescan`)
-  - Fee estimation (`/v1/fees/estimate`)
   - Peer management (`/v1/peers`)
 - Docker support with multi-stage builds (13MB final image)
 - Docker Compose configuration with Bitcoin Core regtest example
@@ -136,7 +138,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - RESTful JSON API
 - Configurable via CLI flags or environment variables
 
-[Unreleased]: https://github.com/yourusername/neutrino-api/compare/v0.3.0...HEAD
+[Unreleased]: https://github.com/yourusername/neutrino-api/compare/v0.5.0...HEAD
+[0.5.0]: https://github.com/yourusername/neutrino-api/compare/v0.4.0...v0.5.0
+[0.4.0]: https://github.com/yourusername/neutrino-api/compare/v0.3.0...v0.4.0
 [0.3.0]: https://github.com/yourusername/neutrino-api/compare/v0.2.0...v0.3.0
 [0.2.0]: https://github.com/yourusername/neutrino-api/compare/v0.1.0...v0.2.0
 [0.1.0]: https://github.com/yourusername/neutrino-api/releases/tag/v0.1.0

README.md

@@ -313,22 +313,6 @@ curl -X POST http://localhost:8334/v1/rescan \
   }'
 ```
 
-### Fee Estimation
-
-Get estimated fee rate for target confirmation blocks:
-
-```bash
-curl "http://localhost:8334/v1/fees/estimate?target_blocks=6"
-```
-
-Response:
-```json
-{
-  "fee_rate": 5,
-  "target_blocks": 6
-}
-```
-
 ### Peers
 
 Get connected peer information:

neutrino_server/e2e/mainnet_test.go

@@ -99,12 +99,6 @@ type PeersResponse struct {
 	Count int   `json:"count"`
 }
 
-// FeeEstimateResponse represents the /v1/fees/estimate response
-type FeeEstimateResponse struct {
-	FeeRate      int `json:"fee_rate"`
-	TargetBlocks int `json:"target_blocks"`
-}
-
 // UTXOsResponse represents the /v1/utxos response
 type UTXOsResponse struct {
 	UTXOs []struct {
@@ -192,7 +186,6 @@ func TestMainnetE2E(t *testing.T) {
 	t.Run("GenesisBlock", func(t *testing.T) { testGenesisBlock(t, baseURL) })
 	t.Run("Block100000", func(t *testing.T) { testBlock100000(t, baseURL) })
 	t.Run("Block500000", func(t *testing.T) { testBlock500000(t, baseURL) })
-	t.Run("FeeEstimate", func(t *testing.T) { testFeeEstimate(t, baseURL) })
 	t.Run("WatchAddress", func(t *testing.T) { testWatchAddress(t, baseURL) })
 	t.Run("UTXOs", func(t *testing.T) { testUTXOs(t, baseURL) })
 }
@@ -504,25 +497,6 @@ func testBlock500000(t *testing.T, baseURL string) {
 	}
 }
 
-func testFeeEstimate(t *testing.T, baseURL string) {
-	var fee FeeEstimateResponse
-	if err := getJSON(t, baseURL, "/v1/fees/estimate?target_blocks=6", &fee); err != nil {
-		t.Fatalf("Failed to get fee estimate: %v", err)
-	}
-
-	t.Logf("Fee estimate: fee_rate=%d sat/vB, target_blocks=%d", fee.FeeRate, fee.TargetBlocks)
-
-	// Fee rate should be positive
-	if fee.FeeRate <= 0 {
-		t.Errorf("Fee rate should be positive, got %d", fee.FeeRate)
-	}
-
-	// Target blocks should match our request
-	if fee.TargetBlocks != 6 {
-		t.Errorf("Target blocks should be 6, got %d", fee.TargetBlocks)
-	}
-}
-
 func testWatchAddress(t *testing.T, baseURL string) {
 	// Watch Satoshi's address
 	body := fmt.Sprintf(`{"address": "%s"}`, satoshiAddress)

neutrino_server/internal/api/handler.go

@@ -68,9 +68,6 @@ func (h *Handler) RegisterRoutes(r *mux.Router) {
 	// Rescan
 	r.HandleFunc("/v1/rescan", h.handleRescan).Methods("POST")
 
-	// Fee estimation
-	r.HandleFunc("/v1/fees/estimate", h.handleEstimateFee).Methods("GET")
-
 	// Peers
 	r.HandleFunc("/v1/peers", h.handleGetPeers).Methods("GET")
 }
@@ -317,35 +314,6 @@ func (h *Handler) handleRescan(w http.ResponseWriter, r *http.Request) {
 	})
 }
 
-// Fee estimation endpoint
-func (h *Handler) handleEstimateFee(w http.ResponseWriter, r *http.Request) {
-	targetBlocks := 6 // default
-	if tb := r.URL.Query().Get("target_blocks"); tb != "" {
-		if parsed, err := strconv.Atoi(tb); err == nil {
-			targetBlocks = parsed
-		}
-	}
-
-	// Neutrino doesn't have mempool-based fee estimation
-	// Return reasonable defaults based on target
-	var feeRate int
-	switch {
-	case targetBlocks <= 1:
-		feeRate = 20
-	case targetBlocks <= 3:
-		feeRate = 10
-	case targetBlocks <= 6:
-		feeRate = 5
-	default:
-		feeRate = 2
-	}
-
-	h.jsonResponse(w, map[string]any{
-		"fee_rate":      feeRate,
-		"target_blocks": targetBlocks,
-	})
-}
-
 // Peers endpoint
 func (h *Handler) handleGetPeers(w http.ResponseWriter, r *http.Request) {
 	status := h.node.GetStatus()