Create a simple example that works on ESP32-S3 devices #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for PR. By the way, the sample you added looks like it could be integrated into PlotToSerial. |
Contributor
Author
|
@GOB52, I've set the merge destination to be the develop branch :) Yeah, it probably could be added in there too. I think a super simple example without the PlotToSerial stuff would also be beneficial (as is included in the PR). Thanks for reviewing. |
Contributor
|
@smebberson |
Contributor
Author
|
Looks great :) Thank you! |
Contributor
|
Moving to #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple example showing how to display the current range on an ESP32-S3 based device. A link to this could be placed next to the current link (https://github.com/m5stack/M5Stack/blob/master/examples/Unit/ToF_VL53L0X/ToF_VL53L0X.ino) on https://docs.m5stack.com/en/unit/tof (under the Arduino heading) informing users this is an example that will work on ESP32-S*, ESP32-C* devices.