Skip to content

Commit def45a5

Browse files
committed
mP1/walkingkooka-environment#92 EnvironmentContextDelegator.setEnvironmentValue
- mP1/walkingkooka-environment#92 - EnvironmentContextDelegator.setEnvironmentValue
1 parent 5fd7593 commit def45a5

File tree

5 files changed

+36
-22
lines changed

5 files changed

+36
-22
lines changed

src/main/java/walkingkooka/spreadsheet/engine/SpreadsheetEngineContextDelegator.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,17 @@ default LocaleContext localeContext() {
151151
return this.spreadsheetEngineContext();
152152
}
153153

154+
@Override
155+
default <T> SpreadsheetEngineContext setEnvironmentValue(final EnvironmentValueName<T> name,
156+
final T value) {
157+
this.environmentContext()
158+
.setEnvironmentValue(
159+
name,
160+
value
161+
);
162+
return this;
163+
}
164+
154165
@Override
155166
default SpreadsheetEngineContext removeEnvironmentValue(final EnvironmentValueName<?> name) {
156167
this.spreadsheetEngineContext()

src/main/java/walkingkooka/spreadsheet/expression/CellSpreadsheetExpressionEvaluationContext.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
package walkingkooka.spreadsheet.expression;
1919

20-
import walkingkooka.environment.EnvironmentValueName;
2120
import walkingkooka.spreadsheet.SpreadsheetCell;
2221
import walkingkooka.spreadsheet.format.SpreadsheetFormatterContext;
2322
import walkingkooka.spreadsheet.reference.SpreadsheetCellRangeReference;
@@ -140,16 +139,6 @@ public SpreadsheetValidatorContext validatorContext(final SpreadsheetExpressionR
140139

141140
// EnvironmentContext...............................................................................................
142141

143-
@Override
144-
public <T> SpreadsheetExpressionEvaluationContext setEnvironmentValue(final EnvironmentValueName<T> name,
145-
final T value) {
146-
this.context.setEnvironmentValue(
147-
name,
148-
value
149-
);
150-
return this;
151-
}
152-
153142
private final SpreadsheetExpressionEvaluationContext context;
154143

155144
@Override

src/main/java/walkingkooka/spreadsheet/expression/SpreadsheetExpressionEvaluationContextDelegator.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,22 @@ default SpreadsheetExpressionEvaluationContext expressionEvaluationContext() {
9595

9696
// StorageExpressionEvaluationContextDelegator......................................................................
9797

98+
@Override
99+
default <T> SpreadsheetExpressionEvaluationContext setEnvironmentValue(final EnvironmentValueName<T> name,
100+
final T value) {
101+
this.spreadsheetExpressionEvaluationContext()
102+
.setEnvironmentValue(
103+
name,
104+
value
105+
);
106+
return this;
107+
}
108+
98109
@Override
99110
default SpreadsheetExpressionEvaluationContext removeEnvironmentValue(final EnvironmentValueName<?> name) {
100-
throw new UnsupportedOperationException();
111+
this.spreadsheetExpressionEvaluationContext()
112+
.removeEnvironmentValue(name);
113+
return this;
101114
}
102115

103116
@Override

src/main/java/walkingkooka/spreadsheet/format/SpreadsheetFormatterProviderSamplesContextDelegator.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@ default SpreadsheetFormatterContext spreadsheetFormatterContext() {
3838

3939
// ProviderContextDelegator.........................................................................................
4040

41+
@Override
42+
default <T> SpreadsheetFormatterProviderSamplesContext setEnvironmentValue(final EnvironmentValueName<T> name,
43+
final T value) {
44+
this.environmentContext()
45+
.setEnvironmentValue(
46+
name,
47+
value
48+
);
49+
return this;
50+
}
51+
4152
@Override
4253
default SpreadsheetFormatterProviderSamplesContext removeEnvironmentValue(final EnvironmentValueName<?> name) {
4354
this.spreadsheetFormatterProviderSamplesContext()

src/test/java/walkingkooka/spreadsheet/engine/SpreadsheetEngineContextDelegatorTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,12 @@
1717

1818
package walkingkooka.spreadsheet.engine;
1919

20-
import walkingkooka.environment.EnvironmentValueName;
2120
import walkingkooka.plugin.store.PluginStore;
2221
import walkingkooka.reflect.ClassTesting;
2322
import walkingkooka.reflect.JavaVisibility;
2423
import walkingkooka.spreadsheet.reference.SpreadsheetLabelName;
2524
import walkingkooka.spreadsheet.reference.SpreadsheetSelection;
2625

27-
import java.util.Objects;
2826
import java.util.Optional;
2927

3028
public final class SpreadsheetEngineContextDelegatorTest implements ClassTesting<SpreadsheetEngineContextDelegator> {
@@ -44,14 +42,6 @@ public PluginStore pluginStore() {
4442
public Optional<SpreadsheetSelection> resolveLabel(final SpreadsheetLabelName labelName) {
4543
throw new UnsupportedOperationException();
4644
}
47-
48-
@Override
49-
public <T> TestSpreadsheetEngineContextDelegator setEnvironmentValue(final EnvironmentValueName<T> name,
50-
final T value) {
51-
Objects.requireNonNull(name, "name");
52-
Objects.requireNonNull(value, "value");
53-
throw new UnsupportedOperationException();
54-
}
5545
}
5646

5747
// class............................................................................................................

0 commit comments

Comments
 (0)