SpreadsheetViewportAnchor.urlFragment empty when NONE

Author: mP1

src/main/java/walkingkooka/spreadsheet/viewport/SpreadsheetViewportAnchor.java

@@ -48,7 +48,14 @@ public enum SpreadsheetViewportAnchor implements HasUrlFragment {
     RIGHT;
 
     SpreadsheetViewportAnchor() {
-        this.kebabText = CaseKind.kebabEnumName(this);
+        final String kebabText = CaseKind.SNAKE.change(
+            this.name(),
+            CaseKind.KEBAB
+        );
+        this.kebabText = kebabText;
+        this.urlFragment = kebabText.equals("none") ?
+            UrlFragment.EMPTY :
+            UrlFragment.with(kebabText);
     }
 
     public String kebabText() {
@@ -221,14 +228,11 @@ private void failIfNone() {
 
     @Override
     public UrlFragment urlFragment() {
-        return UrlFragment.with(
-            CaseKind.SNAKE.change(
-                this.name(),
-                CaseKind.KEBAB
-            )
-        );
+        return this.urlFragment;
     }
 
+    private final UrlFragment urlFragment;
+
     public final static SpreadsheetViewportAnchor CELL = NONE;
     public final static SpreadsheetViewportAnchor COLUMN = NONE;
     public final static SpreadsheetViewportAnchor ROW = NONE;

src/test/java/walkingkooka/spreadsheet/viewport/SpreadsheetViewportAnchorTest.java

@@ -18,6 +18,8 @@
 package walkingkooka.spreadsheet.viewport;
 
 import org.junit.jupiter.api.Test;
+import walkingkooka.net.HasUrlFragmentTesting;
+import walkingkooka.net.UrlFragment;
 import walkingkooka.reflect.ClassTesting;
 import walkingkooka.reflect.JavaVisibility;
 import walkingkooka.spreadsheet.reference.SpreadsheetCellRangeReference;
@@ -33,7 +35,8 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 public final class SpreadsheetViewportAnchorTest implements ClassTesting<SpreadsheetViewportAnchor>,
-    ParseStringTesting<SpreadsheetViewportAnchor> {
+    ParseStringTesting<SpreadsheetViewportAnchor>,
+    HasUrlFragmentTesting {
 
     // constants........................................................................................................
 
@@ -109,33 +112,6 @@ private void oppositeAndCheck2(final SpreadsheetViewportAnchor anchor,
         );
     }
 
-    // kebabText........................................................................................................
-
-    @Test
-    public void testKebabTextLeft() {
-        this.kebabTextAndCheck(
-            SpreadsheetViewportAnchor.LEFT,
-            "left"
-        );
-    }
-
-    @Test
-    public void testKebabTextTopRight() {
-        this.kebabTextAndCheck(
-            SpreadsheetViewportAnchor.TOP_RIGHT,
-            "top-right"
-        );
-    }
-
-    private void kebabTextAndCheck(final SpreadsheetViewportAnchor anchor,
-                                   final String expected) {
-        this.checkEquals(
-            expected,
-            anchor.kebabText(),
-            () -> anchor + " kebabText"
-        );
-    }
-
     // setLeft........................................................................................................
 
     @Test
@@ -921,6 +897,32 @@ private void toRowOrRowRangeAnchorAndCheck(final SpreadsheetViewportAnchor ancho
         );
     }
 
+    // HasUrlFragment...................................................................................................
+
+    @Test
+    public void testUrlFragmentNone() {
+        this.urlFragmentAndCheck(
+            SpreadsheetViewportAnchor.NONE,
+            UrlFragment.EMPTY
+        );
+    }
+
+    @Test
+    public void testUrlFragmentTopLeft() {
+        this.urlFragmentAndCheck(
+            SpreadsheetViewportAnchor.TOP_LEFT,
+            "top-left"
+        );
+    }
+
+    @Test
+    public void testUrlFragmentLeft() {
+        this.urlFragmentAndCheck(
+            SpreadsheetViewportAnchor.LEFT,
+            "left"
+        );
+    }
+
     // ClassTesting....................................................................................................
 
     @Override