Merge pull request #843 from gmetais/fix-object-errors

macbre · web-flow · commit d606b950b66c · 2021-01-04T18:11:14.000+01:00
Fix object errors
diff --git a/lib/index.js b/lib/index.js
@@ -89,8 +89,14 @@ function phantomas(url, opts) {
 
         // @see https://github.com/GoogleChrome/puppeteer/blob/v1.11.0/docs/api.md#pageevaluateonnewdocumentpagefunction-args
         injectJs: async (script) => {
-          const debug = require("debug")("phantomas:injectJs"),
-            preloadFile = require("fs").readFileSync(script, "utf8");
+          const debug = require("debug")("phantomas:injectJs");
+
+          // Make sure we're on an HTML document, not an XML document for example
+          const prefix = "if (document.constructor.name === 'HTMLDocument') {",
+            suffix = "}";
+
+          const preloadFile =
+            prefix + require("fs").readFileSync(script, "utf8") + suffix;
 
           await page.evaluateOnNewDocument(preloadFile);
 
diff --git a/test/integration-spec.yaml b/test/integration-spec.yaml
@@ -839,6 +839,11 @@
       - { url: "http://127.0.0.1:8888/browser-caching.html", type: "html", size: 517 }
       - { url: "http://127.0.0.1:8888/static/jquery-2.1.1.min.js", type: "js", size: 29734 }
 
+# don't call MutationObserver on <object> tags
+- url: "/svg-as-object.html"
+  metrics:
+    jsErrors: 0
+
 #
 # integration-test-extra section
 #
diff --git a/test/webroot/svg-as-object.html b/test/webroot/svg-as-object.html
@@ -0,0 +1,10 @@
+<body>
+    <!-- 
+        Objects should not throw the following JS errors:
+        
+        TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'
+        TypeError: Cannot read property 'scrollHeight' of null
+        TypeError: Cannot read property 'getElementsByTagName' of null
+     -->
+    <object data="/static/example.svg" type="image/svg+xml"></object>
+</body>

Original file line number	Diff line number	Diff line change
`@@ -839,6 +839,11 @@`
`839`	`839`	`- { url: "http://127.0.0.1:8888/browser-caching.html", type: "html", size: 517 }`
`840`	`840`	`- { url: "http://127.0.0.1:8888/static/jquery-2.1.1.min.js", type: "js", size: 29734 }`
`841`	`841`
	`842`	`+# don't call MutationObserver on <object> tags`
	`843`	`+- url: "/svg-as-object.html"`
	`844`	`+ metrics:`
	`845`	`+ jsErrors: 0`
	`846`	`+`
`842`	`847`	`#`
`843`	`848`	`# integration-test-extra section`
`844`	`849`	`#`