Use standard BUILD_TESTING CMake variable and deprecate WITH_TESTS

* streamline CI configuration

* set find_package to CONFIG for PDAL

* use standard BUILD_TESTING cmake config variable and deprecate WITH_TESTS

* BUILD_TESTING now as is standard in CMake instead of WITH_TESTS, which is not

* remove extraneous include

Author: hobu

.github/workflows/linux.yml

@@ -0,0 +1,69 @@
+name: Test
+on: [push, pull_request]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build:
+    name: OS ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [macos-latest, windows-latest, ubuntu-latest]
+        shared: [ON, OFF]
+
+    steps:
+     - uses: actions/checkout@v4
+     - uses: ilammy/msvc-dev-cmd@v1
+       if: matrix.os == 'windows-latest'
+     - name: Support longpaths
+       run: git config --system core.longpaths true
+       if: matrix.os == 'windows-latest'
+     - uses: mamba-org/setup-micromamba@v1
+       with:
+           init-shell: bash
+           environment-file: ci/environment.yml
+           environment-name: "build"
+           cache-environment: true
+           cache-downloads: true
+
+     - name: Setup
+       shell: bash -l {0}
+       run: |
+           mkdir build
+
+     - name: CMake
+       shell: bash -l {0}
+
+       run: |
+
+        if [ "$RUNNER_OS" == "Windows" ]; then
+        export CC=cl.exe
+        export CXX=cl.exe
+        fi
+
+        cmake   -G "Ninja"  \
+              -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+              -DBUILD_SHARED_LIBS=$BUILD_SHARED_LIBS \
+              -DBUILD_TESTING=ON \
+              -DCMAKE_INSTALL_PREFIX=${CONDA_PREFIX} \
+              -Dgtest_force_shared_crt=ON \
+              ..
+
+
+       working-directory: ./build
+
+     - name: Compile
+       shell: bash -l {0}
+       run: |
+          ninja
+       working-directory: ./build
+
+     - name: Test
+       shell: bash -l {0}
+       run: |
+          ctest -VV --rerun-failed --output-on-failure
+       working-directory: ./build
+

.github/workflows/osx.yml

@@ -3,16 +3,16 @@ project(Untwine VERSION 1.3.2 LANGUAGES CXX)
 include(FeatureSummary)
 include(${PROJECT_SOURCE_DIR}/cmake/compiler_options.cmake)
 
-option(WITH_TESTS
-    "Choose if Untwine unit tests should be built" TRUE)
-add_feature_info("Unit tests" WITH_TESTS "Untwine unit tests")
+option(BUILD_TESTING "Chose if Untwine unit tests should be built" OFF)
+add_feature_info("Unit tests" BUILD_TESTING "Untwine unit tests")
 
-
-find_package(PDAL REQUIRED)
-if ((PDAL_VERSION_MAJOR EQUAL 1) AND (PDAL_VERSION_MINOR LESS 7))
-  message(FATAL_ERROR "PDAL version is too old (${PDAL_VERSION}). Use 1.7 or higher.")
+if(DEFINED WITH_TESTS)
+  message(DEPRECATION "WITH_TESTS has been replaced with the standard CMake BUILD_TESTING variable")
+  set(BUILD_TESTING ${WITH_TESTS})
 endif()
 
+find_package(PDAL REQUIRED CONFIG 2.6)
+
 find_package(Threads)
 set_package_properties(Threads PROPERTIES DESCRIPTION
     "The thread library of the system" TYPE REQUIRED)
@@ -58,9 +58,7 @@ endif()
 
 install(TARGETS untwine DESTINATION bin)
 
-#-----------------
-
-if (WITH_TESTS)
+if (BUILD_TESTING)
     enable_testing()
     add_subdirectory(test)
 endif()