Merge pull request #1357 from mackerelio/workflow-sha-pinning

yseto · web-flow · commit bb697d3eea32 · 2025-11-04T13:13:06.000+09:00
update CI
diff --git a/.github/workflows/create-release-pr.yml b/.github/workflows/create-release-pr.yml
@@ -17,11 +17,11 @@ jobs:
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
-      - uses: shogo82148/actions-setup-perl@5796a908661aa68fc0a5b8f55c6791af2376d72e # v1.35.0
+      - uses: shogo82148/actions-setup-perl@f9f0bf89e0d19ddbabb2f40d43db2e944bce7d2f # v1.36.0
         with:
           perl-version: "5.34"
 
-      - uses: mackerelio/mackerel-create-release-pull-request-action@main
+      - uses: mackerelio/mackerel-create-release-pull-request-action@c30e6538510d81ac7acb49cbadd7a6d15162006d # v0.0.1
         id: start
         with:
           github_token: ${{ secrets.MACKERELBOT_GITHUB_TOKEN }}
@@ -30,7 +30,7 @@ jobs:
           version_go_file_path: mackerel-plugin.go
           ignore_update_program_files: "true"
 
-      - uses: mackerelio/mackerel-create-release-pull-request-action@main
+      - uses: mackerelio/mackerel-create-release-pull-request-action@c30e6538510d81ac7acb49cbadd7a6d15162006d # v0.0.1
         with:
           github_token: ${{ secrets.MACKERELBOT_GITHUB_TOKEN }}
           finished: "true"
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,25 +12,29 @@ env:
   DEBIAN_FRONTEND: noninteractive
 jobs:
   lint:
-    uses: mackerelio/workflows/.github/workflows/go-lint.yml@c7e130d3908894f18068ca4a877e80539b535881 # v1.5.0
+    uses: mackerelio/workflows/.github/workflows/go-lint.yml@7653987676cc233af59a390d142b5cf6e65a526f # v1.6.0
     with:
       os-versions: '["ubuntu-latest", "windows-2025"]'
   test:
-    uses: mackerelio/workflows/.github/workflows/go-test.yml@c7e130d3908894f18068ca4a877e80539b535881 # v1.5.0
+    uses: mackerelio/workflows/.github/workflows/go-test.yml@7653987676cc233af59a390d142b5cf6e65a526f # v1.6.0
     with:
       os-versions: '["ubuntu-latest", "windows-2025"]'
+      pre: |
+        echo "GOTOOLCHAIN=auto" >> $GITHUB_ENV
   integration-test-linux:
-    uses: mackerelio/workflows/.github/workflows/setup-go-matrix.yml@c7e130d3908894f18068ca4a877e80539b535881 # v1.5.0
+    uses: mackerelio/workflows/.github/workflows/setup-go-matrix.yml@7653987676cc233af59a390d142b5cf6e65a526f # v1.6.0
     with:
       os-versions: '["ubuntu-latest"]'
       run: |
+        export GOTOOLCHAIN=auto
         make testconvention
         ./test.bash
   integration-test-windows:
-    uses: mackerelio/workflows/.github/workflows/setup-go-matrix.yml@c7e130d3908894f18068ca4a877e80539b535881 # v1.5.0
+    uses: mackerelio/workflows/.github/workflows/setup-go-matrix.yml@7653987676cc233af59a390d142b5cf6e65a526f # v1.6.0
     with:
       os-versions: '["windows-2025"]'
       run: |
+        export GOTOOLCHAIN=auto
         go build -o mackerel-plugin-mssql/mackerel-plugin-mssql.exe ./mackerel-plugin-mssql
         go build -o mackerel-plugin-windows-server-sessions/mackerel-plugin-windows-server-sessions.exe ./mackerel-plugin-windows-server-sessions
   build:
@@ -49,7 +53,7 @@ jobs:
         with:
           go-version: 1.24.x
       - run: make clean rpm deb tar
-      - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+      - uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         with:
           name: linux-build-artifacts
           path: |
@@ -62,17 +66,17 @@ jobs:
     runs-on: ubuntu-latest
     if: github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/v')
     steps:
-      - uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
+      - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
         with:
           name: linux-build-artifacts
           path: artifacts/
-      - uses: mackerelio/staging-release-update-action@main
+      - uses: mackerelio/staging-release-update-action@bc0e3a9f7bd0d890dc044592a798bc307bacc956 # v0.0.1
         if: github.ref == 'refs/heads/master'
         with:
           directory: artifacts/
           github-token: ${{ secrets.GITHUB_TOKEN }}
           tag: staging
-      - uses: mackerelio/create-release-action@main
+      - uses: mackerelio/create-release-action@5af34070474b72efdb3f5057e50d2f3836453c56 # v0.0.4
         if: startsWith(github.ref, 'refs/tags/v')
         with:
           directory: artifacts/
diff --git a/.golangci.yml b/.golangci.yml
@@ -1,14 +1,28 @@
-run:
-  timeout: 5m
+version: "2"
 linters:
-  # see also https://golangci-lint.run/usage/linters/#enabled-by-default
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - errcheck
+          - ineffassign
+          - staticcheck
+        path: _test\.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
   enable:
-   - gofmt
-issues:
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - errcheck
-        - gosimple
-        - staticcheck
-        - ineffassign
+    - gofmt
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
diff --git a/mackerel-plugin-aws-ec2-ebs/lib/aws-ec2-ebs.go b/mackerel-plugin-aws-ec2-ebs/lib/aws-ec2-ebs.go
@@ -422,7 +422,7 @@ func (p EBSPlugin) FetchMetrics() (map[string]interface{}, error) {
 						return nil, err
 					}
 				} else {
-					stat[strings.Replace(metricKey, "#", volumeID, -1)] = val
+					stat[strings.ReplaceAll(metricKey, "#", volumeID)] = val
 				}
 			}
 		}
@@ -436,7 +436,7 @@ func (p EBSPlugin) GraphDefinition() map[string]mp.Graphs {
 }
 
 func normalizeVolumeID(volumeID string) string {
-	return strings.Replace(volumeID, ".", "_", -1)
+	return strings.ReplaceAll(volumeID, ".", "_")
 }
 
 // overwritten with syscall.SIGTERM on unix environment (see aws-ec2-ebs_unix.go)
diff --git a/mackerel-plugin-conntrack/lib/conntrack.go b/mackerel-plugin-conntrack/lib/conntrack.go
@@ -35,7 +35,7 @@ func FindFile(paths []string) (f string, err error) {
 		}
 	}
 
-	return "", fmt.Errorf("Cannot find files %s", paths)
+	return "", fmt.Errorf("Cannot find files %s", paths) // nolint
 }
 
 // CurrentValue returns a value from a file.
diff --git a/mackerel-plugin-elasticsearch/lib/elasticsearch.go b/mackerel-plugin-elasticsearch/lib/elasticsearch.go
@@ -77,14 +77,14 @@ func getFloatValue(s map[string]interface{}, keys []string) (float64, error) {
 			case map[string]interface{}:
 				sm = sm[k].(map[string]interface{})
 			default:
-				return 0, errors.New("Cannot handle as a hash")
+				return 0, errors.New("Cannot handle as a hash") // nolint
 			}
 		} else {
 			switch sm[k].(type) {
 			case float64:
 				val = sm[k].(float64)
 			default:
-				return 0, errors.New("Not float64")
+				return 0, errors.New("Not float64") // nolint
 			}
 		}
 	}
@@ -137,7 +137,7 @@ func (p ElasticsearchPlugin) FetchMetrics() (map[string]float64, error) {
 	n := ""
 	for k := range nodes {
 		if n != "" {
-			return nil, errors.New("Multiple node found")
+			return nil, errors.New("Multiple node found") // nolint
 		}
 		n = k
 	}
diff --git a/mackerel-plugin-haproxy/lib/haproxy.go b/mackerel-plugin-haproxy/lib/haproxy.go
@@ -83,7 +83,7 @@ func (p HAProxyPlugin) fetchMetricsFromTCP() (map[string]float64, error) {
 	defer resp.Body.Close()
 
 	if resp.StatusCode != 200 {
-		return nil, fmt.Errorf("Request failed. Status: %s, URI: %s", resp.Status, requestURI)
+		return nil, fmt.Errorf("Request failed. Status: %s, URI: %s", resp.Status, requestURI) // nolint
 	}
 
 	return p.parseStats(resp.Body)
diff --git a/mackerel-plugin-linux/lib/linux.go b/mackerel-plugin-linux/lib/linux.go
@@ -243,11 +243,12 @@ func parseProcStat(r io.Reader, p *map[string]interface{}) error {
 			return errParse
 		}
 
-		if name == "intr" {
+		switch name {
+		case "intr":
 			(*p)["interrupts"] = value
-		} else if name == "ctxt" {
+		case "ctxt":
 			(*p)["context_switches"] = value
-		} else if name == "processes" {
+		case "processes":
 			(*p)["forks"] = value
 		}
 	}
diff --git a/mackerel-plugin-mssql/lib/mssql_windows.go b/mackerel-plugin-mssql/lib/mssql_windows.go
@@ -79,7 +79,7 @@ func (m MSSQLPlugin) FetchMetrics() (map[string]float64, error) {
 
 // GraphDefinition interface for mackerelplugin
 func (m MSSQLPlugin) GraphDefinition() map[string](mp.Graphs) {
-	labelPrefix := cases.Title(language.Und, cases.NoLower).String(strings.Replace(m.MetricKeyPrefix(), "mssql", "MSSQL", -1))
+	labelPrefix := cases.Title(language.Und, cases.NoLower).String(strings.ReplaceAll(m.MetricKeyPrefix(), "mssql", "MSSQL"))
 	return map[string](mp.Graphs){
 		"buffer": mp.Graphs{
 			Label: labelPrefix + " Buffer",
diff --git a/mackerel-plugin-multicore/lib/multicore.go b/mackerel-plugin-multicore/lib/multicore.go
@@ -186,7 +186,7 @@ func fetchSavedItem(tempFileName string) (*saveItem, error) {
 
 func calcCPUUsage(currentValues map[string]procStats, now time.Time, savedItem *saveItem) ([]cpuPercentages, error) {
 	if now.Sub(savedItem.LastTime).Seconds() > 600 {
-		return nil, errors.New("Too long duration")
+		return nil, errors.New("Too long duration") // nolint
 	}
 
 	var result []cpuPercentages
diff --git a/mackerel-plugin-openldap/lib/openldap.go b/mackerel-plugin-openldap/lib/openldap.go
@@ -49,7 +49,7 @@ func transformKeyName(key string) string {
 	if len(results) < 2 {
 		return ""
 	}
-	return strings.Replace(strings.ToLower(strings.TrimSpace(results[1])), " ", "_", -1)
+	return strings.ReplaceAll(strings.ToLower(strings.TrimSpace(results[1])), " ", "_")
 }
 
 func getStats(sr *ldap.SearchResult, prefix string) map[string]float64 {
diff --git a/mackerel-plugin-php-fpm/lib/php-fpm.go b/mackerel-plugin-php-fpm/lib/php-fpm.go
@@ -201,7 +201,7 @@ func (p PhpFpmPlugin) GraphDefinition() map[string]mp.Graphs {
 func (p PhpFpmPlugin) FetchMetrics() (map[string]interface{}, error) {
 	status, err := getStatus(p)
 	if err != nil {
-		return nil, fmt.Errorf("Failed to fetch PHP-FPM metrics: %s", err)
+		return nil, fmt.Errorf("Failed to fetch PHP-FPM metrics: %s", err) // nolint
 	}
 
 	result := map[string]interface{}{
diff --git a/mackerel-plugin-solr/lib/solr.go b/mackerel-plugin-solr/lib/solr.go
@@ -216,7 +216,7 @@ func (s *SolrPlugin) loadStats() error {
 }
 
 func escapeSlash(slashIncludedString string) (str string) {
-	str = strings.Replace(slashIncludedString, "/", "", -1)
+	str = strings.ReplaceAll(slashIncludedString, "/", "")
 	return
 }
 
diff --git a/mackerel-plugin-twemproxy/lib/twemproxy.go b/mackerel-plugin-twemproxy/lib/twemproxy.go
@@ -123,7 +123,7 @@ func (p TwemproxyPlugin) GraphDefinition() map[string]mp.Graphs {
 func (p TwemproxyPlugin) FetchMetrics() (map[string]interface{}, error) {
 	stats, err := getStats(p)
 	if err != nil {
-		return nil, fmt.Errorf("Failed to fetch twemproxy metrics: %s", err)
+		return nil, fmt.Errorf("Failed to fetch twemproxy metrics: %s", err) // nolint
 	}
 
 	metrics := make(map[string]interface{})
diff --git a/mackerel-plugin-unicorn/lib/unicorn_memory.go b/mackerel-plugin-unicorn/lib/unicorn_memory.go
@@ -14,7 +14,7 @@ func workersMemory() (string, error) {
 		[]string{"awk", "{m+=$6*1024} END{print m;}"},
 	)
 	if err != nil {
-		return "", fmt.Errorf("Cannot get unicorn workers memory: %s", err)
+		return "", fmt.Errorf("Cannot get unicorn workers memory: %s", err) // nolint
 	}
 	return strings.Trim(string(out), "\n"), nil
 }
@@ -27,7 +27,7 @@ func masterMemory() (string, error) {
 		[]string{"awk", "{m+=$6*1024} END{print m;}"},
 	)
 	if err != nil {
-		return "", fmt.Errorf("Cannot get unicorn master memory: %s", err)
+		return "", fmt.Errorf("Cannot get unicorn master memory: %s", err) // nolint
 	}
 	return strings.Trim(string(out), "\n"), nil
 }
@@ -40,7 +40,7 @@ func workersMemoryAvg() (string, error) {
 		[]string{"awk", "{mem=$6*1024+mem; proc++} END{print mem/proc}"},
 	)
 	if err != nil {
-		return "", fmt.Errorf("Cannot get unicorn memory average: %s", err)
+		return "", fmt.Errorf("Cannot get unicorn memory average: %s", err) // nolint
 	}
 	return strings.Trim(string(out), "\n"), nil
 }
diff --git a/mackerel-plugin-unicorn/lib/unicorn_worker.go b/mackerel-plugin-unicorn/lib/unicorn_worker.go
@@ -44,7 +44,7 @@ func fetchUnicornWorkerPids(m string) ([]string, error) {
 
 	out, err := command.Output("ps", "wh", "--ppid", m)
 	if err != nil {
-		return workerPids, fmt.Errorf("Failed to ps of command: %s", err)
+		return workerPids, fmt.Errorf("Failed to ps of command: %s", err) // nolint
 	}
 
 	for _, line := range strings.Split(string(out), "\n") {
@@ -62,7 +62,7 @@ func fetchUnicornWorkerPids(m string) ([]string, error) {
 		return workerPids, nil
 	}
 
-	return workerPids, fmt.Errorf("Cannot get unicorn worker pids")
+	return workerPids, fmt.Errorf("Cannot get unicorn worker pids") // nolint
 }
 
 func cpuTime(pid string) (string, error) {
@@ -71,7 +71,7 @@ func cpuTime(pid string) (string, error) {
 		[]string{"awk", "{print $14+$15}"},
 	)
 	if err != nil {
-		return "", fmt.Errorf("Failed to cat /proc/%s/stat: %s", pid, err)
+		return "", fmt.Errorf("Failed to cat /proc/%s/stat: %s", pid, err) // nolint
 	}
 
 	return strings.Trim(string(out), "\n"), nil
diff --git a/mackerel-plugin-uptime/lib/uptime.go b/mackerel-plugin-uptime/lib/uptime.go
@@ -41,7 +41,7 @@ func (u UptimePlugin) GraphDefinition() map[string]mp.Graphs {
 func (u UptimePlugin) FetchMetrics() (map[string]float64, error) {
 	ut, err := uptime.Get()
 	if err != nil {
-		return nil, fmt.Errorf("Failed to fetch uptime metrics: %s", err)
+		return nil, fmt.Errorf("Failed to fetch uptime metrics: %s", err) // nolint
 	}
 	return map[string]float64{"seconds": ut.Seconds()}, nil
 }
diff --git a/mackerel-plugin-varnish/lib/varnish.go b/mackerel-plugin-varnish/lib/varnish.go
@@ -147,11 +147,12 @@ func (m VarnishPlugin) FetchMetrics() (map[string]interface{}, error) {
 			if smamatch == nil {
 				continue
 			}
-			if smamatch[2] == "g_alloc" {
+			switch smamatch[2] {
+			case "g_alloc":
 				stat["varnish.sma.g_alloc."+smamatch[1]+".g_alloc"] = tmpv
-			} else if smamatch[2] == "g_bytes" {
+			case "g_bytes":
 				stat["varnish.sma.memory."+smamatch[1]+".allocated"] = tmpv
-			} else if smamatch[2] == "g_space" {
+			case "g_space":
 				stat["varnish.sma.memory."+smamatch[1]+".available"] = tmpv
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ func (p EBSPlugin) FetchMetrics() (map[string]interface{}, error) {`
`422`	`422`	`return nil, err`
`423`	`423`	`}`
`424`	`424`	`} else {`
`425`		`- stat[strings.Replace(metricKey, "#", volumeID, -1)] = val`
	`425`	`+ stat[strings.ReplaceAll(metricKey, "#", volumeID)] = val`
`426`	`426`	`}`
`427`	`427`	`}`
`428`	`428`	`}`
`@@ -436,7 +436,7 @@ func (p EBSPlugin) GraphDefinition() map[string]mp.Graphs {`
`436`	`436`	`}`
`437`	`437`
`438`	`438`	`func normalizeVolumeID(volumeID string) string {`
`439`		`- return strings.Replace(volumeID, ".", "_", -1)`
	`439`	`+ return strings.ReplaceAll(volumeID, ".", "_")`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`// overwritten with syscall.SIGTERM on unix environment (see aws-ec2-ebs_unix.go)`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ func FindFile(paths []string) (f string, err error) {`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`
`38`		`- return "", fmt.Errorf("Cannot find files %s", paths)`
	`38`	`+ return "", fmt.Errorf("Cannot find files %s", paths) // nolint`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`// CurrentValue returns a value from a file.`
Original file line number	Diff line number	Diff line change
`@@ -77,14 +77,14 @@ func getFloatValue(s map[string]interface{}, keys []string) (float64, error) {`
`77`	`77`	`case map[string]interface{}:`
`78`	`78`	`sm = sm[k].(map[string]interface{})`
`79`	`79`	`default:`
`80`		`- return 0, errors.New("Cannot handle as a hash")`
	`80`	`+ return 0, errors.New("Cannot handle as a hash") // nolint`
`81`	`81`	`}`
`82`	`82`	`} else {`
`83`	`83`	`switch sm[k].(type) {`
`84`	`84`	`case float64:`
`85`	`85`	`val = sm[k].(float64)`
`86`	`86`	`default:`
`87`		`- return 0, errors.New("Not float64")`
	`87`	`+ return 0, errors.New("Not float64") // nolint`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`	`}`
`@@ -137,7 +137,7 @@ func (p ElasticsearchPlugin) FetchMetrics() (map[string]float64, error) {`
`137`	`137`	`n := ""`
`138`	`138`	`for k := range nodes {`
`139`	`139`	`if n != "" {`
`140`		`- return nil, errors.New("Multiple node found")`
	`140`	`+ return nil, errors.New("Multiple node found") // nolint`
`141`	`141`	`}`
`142`	`142`	`n = k`
`143`	`143`	`}`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ func (p HAProxyPlugin) fetchMetricsFromTCP() (map[string]float64, error) {`
`83`	`83`	`defer resp.Body.Close()`
`84`	`84`
`85`	`85`	`if resp.StatusCode != 200 {`
`86`		`- return nil, fmt.Errorf("Request failed. Status: %s, URI: %s", resp.Status, requestURI)`
	`86`	`+ return nil, fmt.Errorf("Request failed. Status: %s, URI: %s", resp.Status, requestURI) // nolint`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`return p.parseStats(resp.Body)`
Original file line number	Diff line number	Diff line change
`@@ -243,11 +243,12 @@ func parseProcStat(r io.Reader, p *map[string]interface{}) error {`
`243`	`243`	`return errParse`
`244`	`244`	`}`
`245`	`245`
`246`		`- if name == "intr" {`
	`246`	`+ switch name {`
	`247`	`+ case "intr":`
`247`	`248`	`(*p)["interrupts"] = value`
`248`		`- } else if name == "ctxt" {`
	`249`	`+ case "ctxt":`
`249`	`250`	`(*p)["context_switches"] = value`
`250`		`- } else if name == "processes" {`
	`251`	`+ case "processes":`
`251`	`252`	`(*p)["forks"] = value`
`252`	`253`	`}`
`253`	`254`	`}`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ func fetchSavedItem(tempFileName string) (*saveItem, error) {`
`186`	`186`
`187`	`187`	`func calcCPUUsage(currentValues map[string]procStats, now time.Time, savedItem *saveItem) ([]cpuPercentages, error) {`
`188`	`188`	`if now.Sub(savedItem.LastTime).Seconds() > 600 {`
`189`		`- return nil, errors.New("Too long duration")`
	`189`	`+ return nil, errors.New("Too long duration") // nolint`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`var result []cpuPercentages`