port_binary_distributable: output all reasons why a port isn't distributable

An example:

$ ./port_binary_distributable.tcl -v mplayer +glx +faac
"mplayer" is not distributable because its dependency "faac" has license "Restrictive" which is not known to be distributable: faac
"mplayer" is not distributable because its license "gpl" conflicts with license "OpenSSL": mesa -> xorg-libxcb -> python38 -> openssl
"mplayer" is not distributable because its license "gpl" conflicts with license "SSLeay": mesa -> xorg-libxcb -> python38 -> openssl

Author: danchr

jobs/distributable_lib.tcl

@@ -203,6 +203,7 @@ proc remove_version {license} {
 
 proc check_licenses {portName variantInfo} {
     array set portSeen {}
+    set failures {}
     set top_info [infoForPort $portName $variantInfo]
     if {$top_info eq {}} {
         return 1
@@ -228,7 +229,7 @@ proc check_licenses {portName variantInfo} {
         }
         lappend top_license_names $sub_names
         if {!$any_good} {
-            return [list 1 "\"$portName\" is not distributable because its license \"$lic\" is not known to be distributable"]
+            lappend failures "\"$portName\" is not distributable because its license \"$lic\" is not known to be distributable"
         }
     }
 
@@ -241,9 +242,12 @@ proc check_licenses {portName variantInfo} {
 
     while {[llength $portList] > 0} {
         set aPort [lindex $portList 0]
+        set portList [lreplace $portList 0 0]
+        if {[info exists portSeen($aPort)] && $portSeen($aPort) eq 1} {
+            continue
+        }
         # mark as seen and remove from the list
         set portSeen($aPort) 1
-        set portList [lreplace $portList 0 0]
         if {[info exists noconflict_ports($aPort)]} {
             continue
         }
@@ -295,10 +299,9 @@ proc check_licenses {portName variantInfo} {
             }
 
             if {!$any_good} {
-                return [list 1 "\"$portName\" is not distributable because its dependency \"$aPort\" has license \"$lic\" which is not known to be distributable: [join $parentPath " -> "]"]
-            }
-            if {!$any_compatible} {
-                return [list 1 "\"$portName\" is not distributable because its license \"$top_lic\" conflicts with license \"$full_lic\": [join $parentPath " -> "]"]
+                lappend failures "\"$portName\" is not distributable because its dependency \"$aPort\" has license \"$lic\" which is not known to be distributable: [join $parentPath " -> "]"
+            } elseif {!$any_compatible} {
+                lappend failures "\"$portName\" is not distributable because its license \"$top_lic\" conflicts with license \"$full_lic\": [join $parentPath " -> "]"
             }
         }
 
@@ -316,7 +319,11 @@ proc check_licenses {portName variantInfo} {
         }
     }
 
-    return [list 0 "\"$portName\" is distributable"]
+    if {[llength $failures] ne 0} {
+        return [list 1 $failures]
+    } else {
+        return [list 0 [list "\"$portName\" is distributable"]]
+    }
 }
 
 # given a variant string, return an array of variations

jobs/port_binary_distributable.tcl

@@ -93,6 +93,8 @@ if {$dbdir ne ""} {
     write_license_db $dbdir
 }
 if {$verbose} {
-    puts [lindex $results 1]
+    foreach result [lindex $results 1] {
+        puts $result
+    }
 }
 exit [lindex $results 0]