Skip to content

Confirm before disconnecting a connection #6152

Description

@cameronapak

Problem

A single click on Disconnect from Macro drops the grant. That is too easy to fat-finger.

We do not want a user to lose a connector because they tapped the danger button by accident.

Already gated

These already ask first. Reuse them. Do not invent a third confirm pattern if one of these covers it.

  • Google inbox remove in Connections (GoogleProvider) and dest Email. Confirm dialog. Own vs shared copy.
  • Google Calendar off. TurnOffCalendarDialog.
  • Dest Integrations native MCP delete. Inline Confirm / Cancel.

Ungated today

These fire on the first click.

  • GitHub account and GitHub AI (GitHubProvider)
  • Linear, Notion, Slack (PipedreamAiProvider)
  • Cursor (CursorProvider)
  • Other leftovers (OtherView)
  • Dest GitHub card (GitHub.tsx) has the same one-click Disconnect

Ask

Gate every Disconnect and Revoke on Connections (and the dest GitHub card if it stays) so the first click only opens confirm. The second click does the work.

Copy should say what disconnects and what stays. Cursor already tells the truth in the row. Disconnect from Macro deletes Macro's copy of the key. It does not revoke the key in Cursor.

Related PR: #6151

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions