Merge pull request #2 from madetech/TheBranchThatShallNotBeNames

Removing references to... something.

Author: benn-mt

src/models/CattleFactory.js

@@ -18,7 +18,6 @@ export class CattleFactory {
         formData.breed,
         formData.location,
         formData.status || 'Healthy',
-        formData.semenQuality || 'Good',
         formData.imageUrl || null
       );
     } else if (sex === 'Female') {

src/models/MaleCattle.js

@@ -1,28 +1,13 @@
 import { Cattle } from './Cattle';
 
 export class MaleCattle extends Cattle {
-  #semenQuality;
-
-  constructor(id, tag, breed, location, status = 'Healthy', semenQuality = 'Good', imageUrl = null) {
+  constructor(id, tag, breed, location, status = 'Healthy', imageUrl = null) {
     super(id, 'Male', tag, breed, location, status, imageUrl);
-    this.#semenQuality = semenQuality;
-  }
-
-  // Getter
-  get semenQuality() { return this.#semenQuality; }
-
-  // Setter with validation
-  set semenQuality(newQuality) {
-    if (!newQuality) {
-      throw new Error('Semen quality cannot be empty');
-    }
-    this.#semenQuality = newQuality;
   }
 
   toJSON() {
     return {
-      ...super.toJSON(),
-      semenQuality: this.#semenQuality
+      ...super.toJSON()
     };
   }
 } 

src/models/__tests__/Cattle.test.js

@@ -30,7 +30,7 @@ describe('Cattle', () => {
 
 describe('MaleCattle', () => {
   test('creates a male cattle instance with all properties', () => {
-    const cattle = new MaleCattle(1, 'COW001', 'Angus', 'North Pasture', 'Healthy', 'Good', 'image.jpg');
+    const cattle = new MaleCattle(1, 'COW001', 'Angus', 'North Pasture', 'Healthy', 'image.jpg');
 
     expect(cattle.id).toBe(1);
     expect(cattle.tag).toBe('COW001');
@@ -39,7 +39,6 @@ describe('MaleCattle', () => {
     expect(cattle.status).toBe('Healthy');
     expect(cattle.imageUrl).toBe('image.jpg');
     expect(cattle.sex).toBe('Male');
-    expect(cattle.semenQuality).toBe('Good');
   });
 
   test('creates a male cattle from form data', () => {
@@ -48,8 +47,7 @@ describe('MaleCattle', () => {
       tag: 'COW001',
       breed: 'Angus',
       location: 'North Pasture',
-      status: 'Healthy',
-      semenQuality: 'Good'
+      status: 'Healthy'
     };
 
     const cattle = CattleFactory.createFromFormData(formData);
@@ -59,16 +57,14 @@ describe('MaleCattle', () => {
     expect(cattle.location).toBe('North Pasture');
     expect(cattle.status).toBe('Healthy');
     expect(cattle.sex).toBe('Male');
-    expect(cattle.semenQuality).toBe('Good');
   });
 
   test('creates a male cattle from form data with default status', () => {
     const formData = {
       sex: 'Male',
       tag: 'COW001',
       breed: 'Angus',
-      location: 'North Pasture',
-      semenQuality: 'Good'
+      location: 'North Pasture'
     };
 
     const cattle = CattleFactory.createFromFormData(formData);

src/models/__tests__/CattleFactory.test.js

@@ -7,8 +7,7 @@ describe('CattleFactory', () => {
       tag: 'COW001',
       breed: 'Angus',
       location: 'North Pasture',
-      status: 'Healthy',
-      semenQuality: 'Good'
+      status: 'Healthy'
     };
 
     const cattle = CattleFactory.createFromFormData(formData);
@@ -18,7 +17,6 @@ describe('CattleFactory', () => {
     expect(cattle.breed).toBe('Angus');
     expect(cattle.location).toBe('North Pasture');
     expect(cattle.status).toBe('Healthy');
-    expect(cattle.semenQuality).toBe('Good');
   });
 
   test('creates female cattle from form data', () => {
@@ -59,7 +57,6 @@ describe('CattleFactory', () => {
     expect(cattle[0].breed).toBe('Angus');
     expect(cattle[0].location).toBe('North Pasture');
     expect(cattle[0].status).toBe('Healthy');
-    expect(cattle[0].semenQuality).toBe('Good');
 
     // Check first female cattle
     expect(cattle[5].tag).toBe('F001');