Skip to content

Commit b3c3614

Browse files
committed
fix(ci): remove debug step and disable k8s e2e tests
- Remove problematic debug step causing bash parsing errors - Comment out Kubernetes E2E tests (not needed for ECS deployment) - Allow image build workflow to proceed without debug interference
1 parent 2dc3453 commit b3c3614

File tree

2 files changed

+48
-55
lines changed

2 files changed

+48
-55
lines changed

.github/workflows/build-push-images.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,6 @@ jobs:
123123
- name: Checkout code
124124
uses: actions/checkout@v4
125125

126-
- name: Verify service directory
127-
run: |
128-
echo "Current directory: $(pwd)"
129-
echo "Checking for service directory..."
130-
ls -la src/${{ matrix.service }}
131-
echo "Dockerfile exists:"
132-
ls -la src/${{ matrix.service }}/Dockerfile
133-
134126
- name: Set up Docker Buildx
135127
uses: docker/setup-buildx-action@v3
136128

.github/workflows/e2e-test.yml

Lines changed: 48 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -59,50 +59,51 @@ jobs:
5959
run: |
6060
DB_PASSWORD='test123' yarn nx compose:down
6161
62-
kubernetes:
63-
name: Kubernetes E2E Tests
64-
runs-on: ubuntu-latest
65-
steps:
66-
- uses: actions/checkout@v4
67-
- name: "Setup Env"
68-
uses: ./.github/actions/setup-env
69-
70-
- name: Build images
71-
shell: devenv shell bash -- -e {0}
72-
run: |
73-
yarn nx run-many -t build --projects=tag:service --parallel=1
74-
75-
yarn nx run-many -t container --projects=tag:service \
76-
--tags public.ecr.aws/aws-containers/retail-store-sample-{projectName}:e2e --parallel=5
77-
78-
- name: Kind cluster
79-
uses: helm/kind-action@v1.12.0
80-
with:
81-
cluster_name: kind
82-
version: v0.17.0
83-
84-
- name: Load images
85-
env:
86-
IMAGE_TAG: e2e
87-
run: |
88-
kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-catalog:$IMAGE_TAG
89-
kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-cart:$IMAGE_TAG
90-
kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-checkout:$IMAGE_TAG
91-
kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-orders:$IMAGE_TAG
92-
kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-ui:$IMAGE_TAG
93-
94-
docker system prune --all --force
95-
96-
- name: Deploy
97-
shell: devenv shell bash -- -e {0}
98-
env:
99-
IMAGE_TAG: e2e
100-
run: |
101-
NODE_PORT=30000 helmfile apply -f src/app/helmfile.yaml --wait --skip-diff-on-install
102-
103-
kubectl wait --for=condition=Ready pod -l app.kubernetes.io/owner=retail-store-sample --timeout 180s || exit_code=$?
104-
105-
- name: Test
106-
shell: devenv shell bash -- -e {0}
107-
run: |
108-
bash scripts/e2e-kind.sh
62+
# Kubernetes E2E tests commented out - not using Kubernetes for ECS deployment
63+
# kubernetes:
64+
# name: Kubernetes E2E Tests
65+
# runs-on: ubuntu-latest
66+
# steps:
67+
# - uses: actions/checkout@v4
68+
# - name: "Setup Env"
69+
# uses: ./.github/actions/setup-env
70+
#
71+
# - name: Build images
72+
# shell: devenv shell bash -- -e {0}
73+
# run: |
74+
# yarn nx run-many -t build --projects=tag:service --parallel=1
75+
#
76+
# yarn nx run-many -t container --projects=tag:service \
77+
# --tags public.ecr.aws/aws-containers/retail-store-sample-{projectName}:e2e --parallel=5
78+
#
79+
# - name: Kind cluster
80+
# uses: helm/kind-action@v1.12.0
81+
# with:
82+
# cluster_name: kind
83+
# version: v0.17.0
84+
#
85+
# - name: Load images
86+
# env:
87+
# IMAGE_TAG: e2e
88+
# run: |
89+
# kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-catalog:$IMAGE_TAG
90+
# kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-cart:$IMAGE_TAG
91+
# kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-checkout:$IMAGE_TAG
92+
# kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-orders:$IMAGE_TAG
93+
# kind load docker-image public.ecr.aws/aws-containers/retail-store-sample-ui:$IMAGE_TAG
94+
#
95+
# docker system prune --all --force
96+
#
97+
# - name: Deploy
98+
# shell: devenv shell bash -- -e {0}
99+
# env:
100+
# IMAGE_TAG: e2e
101+
# run: |
102+
# NODE_PORT=30000 helmfile apply -f src/app/helmfile.yaml --wait --skip-diff-on-install
103+
#
104+
# kubectl wait --for=condition=Ready pod -l app.kubernetes.io/owner=retail-store-sample --timeout 180s || exit_code=$?
105+
#
106+
# - name: Test
107+
# shell: devenv shell bash -- -e {0}
108+
# run: |
109+
# bash scripts/e2e-kind.sh

0 commit comments

Comments
 (0)