Merge pull request #636 from magefan/magefan-patch-42

magefan · web-flow · commit ed7d1c1c6e4b · 2024-12-26T06:58:24.000-05:00
invalid argument supplied for foreach() in  ShortContentExtractor.php
diff --git a/Model/ShortContentExtractor.php b/Model/ShortContentExtractor.php
@@ -156,8 +156,10 @@ private function setPageBreakOnLen(string $content, $len): string
                 return;
             }
 
-            foreach ($node->childNodes as $child) {
-                $processNode($child);
+            if ($node->childNodes) {
+                foreach ($node->childNodes as $child) {
+                    $processNode($child);
+                }
             }
 
             if ($node->nodeType === XML_TEXT_NODE) {

Original file line number	Diff line number	Diff line change
`@@ -156,8 +156,10 @@ private function setPageBreakOnLen(string $content, $len): string`
`156`	`156`	`return;`
`157`	`157`	`}`
`158`	`158`
`159`		`- foreach ($node->childNodes as $child) {`
`160`		`- $processNode($child);`
	`159`	`+ if ($node->childNodes) {`
	`160`	`+ foreach ($node->childNodes as $child) {`
	`161`	`+ $processNode($child);`
	`162`	`+ }`
`161`	`163`	`}`
`162`	`164`
`163`	`165`	`if ($node->nodeType === XML_TEXT_NODE) {`