Skip to content

v2.1.1 Github tag content does not match repo.magento.com content #1873

Open
@damienwebdev

Description

@damienwebdev

Preconditions (*)

Attempt to install Magento from git tags instead of from composer packages.

Or, equivalently, attempt to write check-summing code to verify that source code is equivalent to release code, and you will find this issue.

Expectation

See that tagged content is the same as released content onto repo.magento.com.

Specifically, https://github.com/magento/adobe-stock-integration/blob/2.1.1/_metapackage/composer.json

vs.

composer show magento/adobe-stock-integration
name     : magento/adobe-stock-integration
descrip. : Adobe Stock integration
keywords : 
versions : * 2.1.1
type     : metapackage
homepage : 
source   : []  
dist     : [zip] https://repo.magento.com/archives/magento/adobe-stock-integration/magento-adobe-stock-integration-2.1.1.0.zip 
path     : /tmp/magento
names    : magento/adobe-stock-integration

requires
magento/adobe-ims *
magento/module-adobe-stock-admin-ui 1.3.0
magento/module-adobe-stock-asset 1.3.0
magento/module-adobe-stock-asset-api 2.0.0
magento/module-adobe-stock-client 1.3.0
magento/module-adobe-stock-client-api 2.1.0
magento/module-adobe-stock-image 1.3.0
magento/module-adobe-stock-image-admin-ui 1.3.0
magento/module-adobe-stock-image-api 1.3.0

Result

Tagged content differs from released content onto repo.magento.com.

The Tag 2.1.1 on Github's composer.json contains

magento/module-adobe-stock-admin-ui: "*"

Whereas the actual release composer.json contains:

magento/module-adobe-stock-admin-ui: "1.3.0"

PR #1872 fixes this.

If you compare:

https://github.com/magento/adobe-stock-integration/blob/2.1.0/_metapackage/composer.json
https://github.com/magento/adobe-stock-integration/blob/2.1.1/_metapackage/composer.json
https://github.com/magento/adobe-stock-integration/blob/2.1.2/_metapackage/composer.json
https://github.com/magento/adobe-stock-integration/blob/2.1.3/_metapackage/composer.json
https://github.com/magento/adobe-stock-integration/blob/2.1.4/_metapackage/composer.json

You will see that only v2.1.1 has this issue. cc: @sidolov @nathanjosiah

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions