Skip to content

Improve Price Book scope validation #472

Open
@lykhachov

Description

@lykhachov

Current approach can lead to performance problems during PR creation with big amoun of price books

Method: \Magento\PricingStorefront\Model\PriceBookRepository::validatePriceBookUnique.

Investigate options to improve this.
For example, we can utilize "JSON" type for and replace existing website/customer_group columns with new column "scopes" with the following structure: {"w": [...], "cg": [...]}, index for both fields should be created

Activity

m2-assistant

m2-assistant commented on Dec 16, 2020

@m2-assistant

Hi @lykhachov. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


changed the title Check JSON approach in storing scope data for Price Books Improve Price Book scope validation on Dec 16, 2020
mslabko

mslabko commented on Dec 16, 2020

@mslabko
Member

@magento export issue to Jira project SFAPP as Task

magento-engcom-team

magento-engcom-team commented on Dec 16, 2020

@magento-engcom-team

✅ Jira issue (https://jira.corp.magento.com/browse/SFAPP-190) is successfully created for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @mslabko@lykhachov@magento-engcom-team@github-jira-sync-bot

      Issue actions

        Improve Price Book scope validation · Issue #472 · magento/catalog-storefront