Skip to content

Commit f785d2b

Browse files
authored
Merge pull request #26 from magento-commerce/php8.4_support
Php8.4 support
2 parents 526da66 + 8afaf3f commit f785d2b

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

.github/workflows/php.yml

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
- "8.1"
1818
- "8.2"
1919
- "8.3"
20+
- "8.4"
2021
dependencies:
2122
- "lowest"
2223
- "highest"

composer.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
"AFL-3.0"
99
],
1010
"require": {
11-
"php": "~7.4.0||~8.1.0||~8.2.0||~8.3.0",
12-
"composer/composer": "^2.0",
11+
"php": "~7.4.0||~8.1.0||~8.2.0||~8.3.0||~8.4.0",
12+
"composer/composer": "^2.1.13",
1313
"symfony/console": "~4.4.0||~5.4.0||~6.4.0"
1414
},
1515
"require-dev": {
16-
"phpunit/phpunit": "^9 || ^10"
16+
"phpunit/phpunit": "^9.5.10 || ^10"
1717
},
1818
"autoload": {
1919
"psr-4": {

src/MagentoComposerApplication.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ class MagentoComposerApplication
6565
public function __construct(
6666
$pathToComposerHome,
6767
$pathToComposerJson,
68-
Application $consoleApplication = null,
69-
ConsoleArrayInputFactory $consoleArrayInputFactory = null,
70-
BufferedOutput $consoleOutput = null
68+
?Application $consoleApplication = null,
69+
?ConsoleArrayInputFactory $consoleArrayInputFactory = null,
70+
?BufferedOutput $consoleOutput = null
7171
) {
7272
$this->consoleApplication = $consoleApplication ? $consoleApplication : new Application();
7373
$this->consoleArrayInputFactory = $consoleArrayInputFactory ? $consoleArrayInputFactory

0 commit comments

Comments
 (0)